Messages are not waited for delivery when disconencted #560
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AssemblyJohn
requested review from
Pietfried,
hikinggrass,
maaikez and
marcemmers
as code owners
AssemblyJohn
force-pushed
the
bugfix/message_fail_on_disconnect
branch
from
dbed633 to
c216e4d
Compare
Pietfried
reviewed
Apr 11, 2024
AssemblyJohn
force-pushed
the
bugfix/message_fail_on_disconnect
branch
from
c216e4d to
598c16a
Compare
…when the WS was offline. On new behavior it quickly fails. - Removed hostname verification if the flag is not on. Signed-off-by: AssemblyJohn <ioan.bogdann@gmail.com>
AssemblyJohn
force-pushed
the
bugfix/message_fail_on_disconnect
branch
from
598c16a to
560770f
Compare
Pietfried
approved these changes
Apr 11, 2024
folkengine
pushed a commit
to US-JOET/libocpp
that referenced
this pull request
Apr 12, 2024
…when the WS was offline. On new behavior it quickly fails. (EVerest#560) - Removed hostname verification if the flag is not on. Signed-off-by: AssemblyJohn <ioan.bogdann@gmail.com>
folkengine
pushed a commit
to US-JOET/libocpp
that referenced
this pull request
Apr 15, 2024
…when the WS was offline. On new behavior it quickly fails. (EVerest#560) - Removed hostname verification if the flag is not on. Signed-off-by: AssemblyJohn <ioan.bogdann@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Messages will not be waited 20 seconds when disconnected, but will fail immediately. Also when the websocket is offline, messages will not be added to the message sending queue.
Issue ticket number and link
Checklist before requesting a review