Convert another logline to debug in libwebsockets #601
Conversation
marcemmers
requested review from
Pietfried,
hikinggrass and
maaikez
as code owners
Pietfried
left a comment
Pietfried
left a comment
There was a problem hiding this comment.
I was thinking about that one as well, since it only logs on larger messages, but ok for me to reduce log level here as well
Signed-off-by: Marc Emmers <m.emmers@alfen.com>
Signed-off-by: Marc Emmers <m.emmers@alfen.com>
Signed-off-by: Marc Emmers <m.emmers@alfen.com>
Signed-off-by: Marc Emmers <m.emmers@alfen.com>
marcemmers
force-pushed
the
another-libwebsocket-logline
branch
from
9495fe5 to
2c87ccf
Compare
Signed-off-by: Marc Emmers <m.emmers@alfen.com>
| } | ||
|
|
||
| void WebsocketTlsTPM::reconnect(long delay) { | ||
| EVLOG_info << "Attempting TLS TPM reconnect with delay:" << delay; |
There was a problem hiding this comment.
I would like this to be kept, and as info, since there were problems with this in the past.
There was a problem hiding this comment.
We print the exact same thing on line 716. If you think it is better I can move remove the line on 716 and leave this one instead?
There was a problem hiding this comment.
I've simply missed that one sorry :). I think this would be better, because if we have a crash or anything in the 'close' this would be the last message printed and would give us a better clue on where the problem might be.
There was a problem hiding this comment.
I will move it to the middle then since it would be a bit strange to print reconnecting and immediately after that print not reconnecting.
| EVLOG_info << "LWS connect with info " | ||
| << "port: [" << i.port << "] address: [" << i.address << "] path: [" << i.path << "] protocol: [" | ||
| << i.protocol << "]"; | ||
| EVLOG_debug << "LWS connect with info " |
There was a problem hiding this comment.
I would keep this as info, it only happens on a connect should not be too spammy.
There was a problem hiding this comment.
It also seems to happen on every reconnect attempt in case the connection does not work. But that is not the reason I removed this one. We also already print the same information in Connecting to uri: etc so I didn't really see a reason to print the same information twice.
Could you elaborate on what you are using from this?
There was a problem hiding this comment.
Sometimes there are some info missing from the uri (in certain contexts), maybe extend this one a bit with TPM and remove the second one? I remember missing some port information from the URI that caused me a lot of headaches.
There was a problem hiding this comment.
I do think the second one is more readable to leave in in the future. I will set this back to info for now, there is already a comment above it that it is for debug anyway so will hopefully be removed sometime in the future.
Signed-off-by: Marc Emmers <m.emmers@alfen.com>
Signed-off-by: Marc Emmers <m.emmers@alfen.com>
Signed-off-by: Marc Emmers <35759328+marcemmers@users.noreply.github.com>
* Convert another logline to debug in libwebsockets Signed-off-by: Marc Emmers <m.emmers@alfen.com> * Clean up a lot of websocket related logging Signed-off-by: Marc Emmers <m.emmers@alfen.com> * Add log line stating which profile we are connecting to Signed-off-by: Marc Emmers <m.emmers@alfen.com> * Make certificate logline debug as well Signed-off-by: Marc Emmers <m.emmers@alfen.com> * Fix linter Signed-off-by: Marc Emmers <m.emmers@alfen.com> * Move one of the log lines a bit and keep as info Signed-off-by: Marc Emmers <m.emmers@alfen.com> * Small review fixes Signed-off-by: Marc Emmers <m.emmers@alfen.com> * Update lib/ocpp/common/websocket/websocket_libwebsockets.cpp Signed-off-by: Marc Emmers <35759328+marcemmers@users.noreply.github.com> --------- Signed-off-by: Marc Emmers <m.emmers@alfen.com> Signed-off-by: Marc Emmers <35759328+marcemmers@users.noreply.github.com>
* Convert another logline to debug in libwebsockets Signed-off-by: Marc Emmers <m.emmers@alfen.com> * Clean up a lot of websocket related logging Signed-off-by: Marc Emmers <m.emmers@alfen.com> * Add log line stating which profile we are connecting to Signed-off-by: Marc Emmers <m.emmers@alfen.com> * Make certificate logline debug as well Signed-off-by: Marc Emmers <m.emmers@alfen.com> * Fix linter Signed-off-by: Marc Emmers <m.emmers@alfen.com> * Move one of the log lines a bit and keep as info Signed-off-by: Marc Emmers <m.emmers@alfen.com> * Small review fixes Signed-off-by: Marc Emmers <m.emmers@alfen.com> * Update lib/ocpp/common/websocket/websocket_libwebsockets.cpp Signed-off-by: Marc Emmers <35759328+marcemmers@users.noreply.github.com> --------- Signed-off-by: Marc Emmers <m.emmers@alfen.com> Signed-off-by: Marc Emmers <35759328+marcemmers@users.noreply.github.com> Signed-off-by: Daniel Moore <9156191+drmrd@users.noreply.github.com>
Describe your changes
Issue ticket number and link
Checklist before requesting a review