Plug&Charge authorization in case OCSP can not be generated #652
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pietfried
requested review from
hikinggrass,
maaikez and
marcemmers
as code owners
…the OCSP could not be generated, e.g. because the contract certificate chain did not contain any OCSP extension. Those contract certificates exist in the real world. This commit changes the behavior in case no OCSP data could be generated. If CentralContractValidationAllowed is true, the certificate is send as part of the Authorize.req instead of rejecting the request directly Signed-off-by: pietfried <pietgoempel@gmail.com>
Pietfried
force-pushed
the
feature/pnc-authorization-in-case-ocsp-can-not-be-generated
branch
from
d9eff54 to
99e452b
Compare
mennodegraaf
reviewed
Jun 3, 2024
| if (central_contract_validation_allowed) { | ||
| EVLOG_info << "Online: OCSP data could not be generated. Pass contract validation to CSMS"; | ||
| authorize_req.certificate = certificate.value(); | ||
| forward_to_csms = true; |
Contributor
There was a problem hiding this comment.
Inconsistency: in the OCPP2.0.1 implementation this is called forwarded_to_csms. Not sure if this requires adjustment.
mennodegraaf
approved these changes
Jun 3, 2024
Contributor
mennodegraaf
left a comment
mennodegraaf
left a comment
There was a problem hiding this comment.
The changes look very straightforward
hikinggrass
approved these changes
Jun 3, 2024
Pietfried
deleted the
feature/pnc-authorization-in-case-ocsp-can-not-be-generated
branch
ghost
pushed a commit
to US-JOET/libocpp
that referenced
this pull request
Jun 12, 2024
…the OCSP could not be generated, e.g. because the contract certificate chain did not contain any OCSP extension. Those contract certificates exist in the real world. This commit changes the behavior in case no OCSP data could be generated. If CentralContractValidationAllowed is true, the certificate is send as part of the Authorize.req instead of rejecting the request directly (EVerest#652) Signed-off-by: pietfried <pietgoempel@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Without this change, a Plug&Charge authorization request failed when the OCSP could not be generated, e.g. because the contract certificate chain did not contain any OCSP extension. Those contract certificates exist in the real world. This commit changes the behavior in case no OCSP data could be generated. If CentralContractValidationAllowed is true, the certificate is send as part of the Authorize.req instead of rejecting the request directly.
Issue ticket number and link
Checklist before requesting a review