OCPP1.6: Fix transaction handling in case of StartTransaction.req retries #688
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pietfried
requested review from
hikinggrass,
maaikez and
marcemmers
as code owners
Pietfried
force-pushed
the
bugfix/update-start-transaction-message-id-on-retry
branch
from
7494772 to
040e959
Compare
…ansaction.req could not be delivered: * StartTransaction.conf handler retrieves a transaction based on the message id of the StartTransaction.req. In case this message is retried, the reference is updated in the message queue but not in the transaction handler * This change updates the start_transaction_message_id of the transaction of the transaction_handler and in the database in case of a retry Signed-off-by: pietfried <pietgoempel@gmail.com>
Pietfried
force-pushed
the
bugfix/update-start-transaction-message-id-on-retry
branch
from
040e959 to
2d7cdad
Compare
hikinggrass
approved these changes
Jul 3, 2024
Pietfried
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Fixed bug that lead to incorrect transaction handling in case StartTransaction.req could not be delivered:
Issue ticket number and link
Checklist before requesting a review