Feature/376 ocpp 201 california pricing requirements tariff and cost #707
Conversation
…allbacks in 'common' so they can be used for both 1.6 and 2.01. Signed-off-by: Maaike Zijderveld, iolar <git.mail@iolar.nl>
Signed-off-by: Maaike Zijderveld, iolar <git.mail@iolar.nl>
…age. Signed-off-by: Maaike Zijderveld, iolar <git.mail@iolar.nl>
Signed-off-by: Maaike Zijderveld, iolar <git.mail@iolar.nl>
Signed-off-by: Maaike Zijderveld, iolar <git.mail@iolar.nl>
…onfig schemas. Signed-off-by: Maaike Zijderveld, iolar <git.mail@iolar.nl>
Signed-off-by: Maaike Zijderveld, iolar <git.mail@iolar.nl>
…or CostAndPrice and multi language. Signed-off-by: Maaike Zijderveld, iolar <git.mail@iolar.nl>
Signed-off-by: Maaike Zijderveld, iolar <git.mail@iolar.nl>
Signed-off-by: Maaike Zijderveld, iolar <git.mail@iolar.nl>
Signed-off-by: Maaike Zijderveld, iolar <git.mail@iolar.nl>
Signed-off-by: Maaike Zijderveld, iolar <git.mail@iolar.nl>
…get / set functions for configurations. Signed-off-by: Maaike Zijderveld, iolar <git.mail@iolar.nl>
… transition date / time. Signed-off-by: Maaike Zijderveld, iolar <git.mail@iolar.nl>
…irements-tariff-and-cost Signed-off-by: Maaike Zijderveld, iolar <git.mail@iolar.nl>
Signed-off-by: Maaike Zijderveld, iolar <git.mail@iolar.nl>
…iguration items in user config. Signed-off-by: Maaike Zijderveld, iolar <git.mail@iolar.nl>
… multiple statusses). Signed-off-by: Maaike Zijderveld, iolar <git.mail@iolar.nl>
Signed-off-by: Maaike Zijderveld, iolar <git.mail@iolar.nl>
Signed-off-by: Maaike Zijderveld, iolar <git.mail@iolar.nl>
Pietfried
left a comment
Pietfried
left a comment
There was a problem hiding this comment.
See in line comments.
The handle_set_user_price and handle_set_session_cost became quite large and I think there is some room to restructure them and improve the readibility (some in line comments already address this)
|
|
||
| json data; | ||
| try { | ||
| data = json(msg.value()); |
There was a problem hiding this comment.
Instead of operating on the raw json I think you could also define a SetUserPrice type like you have done it for RunningCost
There was a problem hiding this comment.
The 'SetUserPrice' translates into display messages here. Because it is in the end a message that should be displayed for a specific transaction. So do you suggest a new type instead of DisplayMessage or a conversion function with the json as input and a vector of display messages as output?
There was a problem hiding this comment.
Do you mean the EVerest DisplayMessage type? This should not be of interest in libocpp. My idea was to define a struct thats initialized by parsing the json instead of operating on the raw json
…x some issues. When session id is not found, return rejected and not send pricing messages. Signed-off-by: Maaike Zijderveld, iolar <git.mail@iolar.nl>
Signed-off-by: Maaike Zijderveld, iolar <git.mail@iolar.nl>
Signed-off-by: Maaike Zijderveld, iolar <git.mail@iolar.nl>
…tomatically checked Signed-off-by: Maaike Zijderveld, iolar <git.mail@iolar.nl>
…irements-tariff-and-cost
Signed-off-by: Maaike Zijderveld, iolar <git.mail@iolar.nl>
| "ISO15118PnCEnabled": true, | ||
| "ContractValidationOffline": true | ||
| }, | ||
| "CostAndPrice": { |
There was a problem hiding this comment.
nit:
Our examples configs are pretty minimal so far, so I would suggest to set CustomDisplayCostAndPrice to false and remove all other keys.
I opened an issue to also provide a fully featured config as part of v16: #736
There was a problem hiding this comment.
ok! i also changed config.json.
Signed-off-by: Maaike Zijderveld, iolar <git.mail@iolar.nl>
Signed-off-by: Maaike Zijderveld, iolar <git.mail@iolar.nl>
…irements-tariff-and-cost
Signed-off-by: Maaike Zijderveld, iolar <git.mail@iolar.nl>
maaikez
deleted the
feature/376-ocpp-201-california-pricing-requirements-tariff-and-cost
branch
Describe your changes
Implement california pricing for 1.6.
Issue ticket number and link
#376
Checklist before requesting a review