Fix reconnect mechanism when basic auth password is set #827
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ivan Rogach <ivan.rogach@alfen.com>
jannejy
requested review from
Pietfried,
hikinggrass,
maaikez and
marcemmers
as code owners
Contributor
|
Looks good, but I am not sure if this has other implications. @hikinggrass what do you think? |
Contributor
|
@maaikez To me it just looks like we are now actually passing on the argument as it was intended. Looking at the call flow there should be no other implications. |
maaikez
approved these changes
Oct 10, 2024
hikinggrass
approved these changes
Oct 10, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Issue ticket number and link
Checklist before requesting a review