Welcome to exer_log Discussions!

[KalleHallden]

Welcome!

We’re using Discussions as a place to connect with each other and for discussions relating to the project.

➡️ You can convert issues to discussions either individually or bulk by labels.

[momshaddinury]

This is great. Now we can freely discuss stuff.

[suzanpradhan]

I guess we need to create a discussion for whole UI update like colors, assets, layouts etc. What do you say?

[momshaddinury]

@jorre127 Do you want to cover that task? It seems like you have a better idea than me about this.

[jorre127]

@dinurymomshad Jup that's fine by me, can we convert this discussion into a issue? or do we have to create a separate issue.

[momshaddinury]

@jorre127 A separate issue since you will only focus on ThemeColors. I suggest adding the files inside the core/theme directory.

[suzanpradhan]

I have created separate discussion just for UI/UX #87 so we can discuss everything related to it then create issues based on the topic.

[jorre127]

@dinurymomshad @suzanpradhan @KalleHallden Implemented the things we discussed in PR #94

[ramsy0dev]

i have found an overflow in the calendar_widget.dart

---

---

and we can fix it by changing the line 43 from

height: screenHeight * 0.4

to

height: screenHeight * 0.43, 

it not somthing big but it may affect the UI.

[momshaddinury]

I am guessing the issue is somewhere else. Judging by the gap between the Calendar widget and the button it should not overflow.

[jorre127]

I think it’s because it’s based on a percentage of the screensize. It’s probably better to just size the calendar based on its content instead.

[ramsy0dev]

yeah you are right

[jorre127]

@KalleHallden I don't know how you would implement this on GitHub, but maybe we should implement a system where a PR has to at least be reviewed by a certain number of people, or a certain group of people, before being merged. Because now some PR's are being merged with some mistakes (pr #99 for example), because nobody has reviewed them at the time. This could create an endless cycle of PR's fixing the code, but then a PR gets merged that doesn't follow the guidelines and then it needs to get fixed again.

[momshaddinury]

Another bug was introduced by #122. We should really focus on adding maintainers. Asking people to add videos/images of before and after would also help. @KalleHallden

[KalleHallden]

Yeah I agree I think this would be very helpful.

[momshaddinury]

@KalleHallden you need to decide who becomes maintainers. And nothing should be merged without testing by pulling the changes in maintainers local and then verifying if everything works.

[momshaddinury]

Also voting for a discord server maintainers channel or something for more convenient communication. I think you already have a server.