Install gala from source with EXP support#21
Merged
Conversation
Member
|
Looks good to me. To Do list
|
Member
|
Looks good to go. Easiest to merge and then check the runner. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the Dockerfile with the following changes:
gala is now installed from source, instead of from PyPI. This allows building gala with EXP support according to the instructions at https://gala.adrian.pw/en/latest/tutorials/exp.html
Removed a checkout of the haloVel branch of pyEXP-examples, as this branch no longer exists.
NOTE: This update requires that the bug fix in PR 218 in the EXP repo is implemented, so that gala compatibility with the main branch of EXP is restored.