-
Notifications
You must be signed in to change notification settings - Fork 5
Add Jupyter notebooks using nbsphinx
#33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Okay, issues seem to be sorted out now. I'm not 100% happy with the intro wording to the pyEXP examples although it's probably good enough. Feel free to edit. |
|
Got the copy buttons to work in the inline Jupyter code blocks. So we have 100% satisfied the referee's requests at this point. |
|
Amazing, the pages look so good! Love that we can see input and output. This addresses openjournals/joss-reviews#7302 (comment). |
|
It isn't 100% 'plug and play'. For example, one would need the data in the repo to really do the examples, even with the copy buttons. I suppose, in retrospect, that's why I whittled down the snippets in ReadTheDocs to standalone bits. Still, I suppose seeing a full up notebook with output is better, even if it would require the pyEXP-examples repo to run. |
Minor wording improvement.
Introductionnotebooks are imported into the ReadTheDocs pyEXP examples chapter, rather than the markdown excerpts.nbsphinxextension is now a dependency and added to bothconf.pyandrequirements.txt