Minor updates for devel compatibility#10
Merged
michael-petersen merged 5 commits intomainfrom Dec 10, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enhances the repository with visualization capabilities and updates configuration files for compatibility with the development branch. The changes focus on making simulation results more accessible through plotting tools.
- Adds Python visualization scripts for plotting orbital trajectories
- Updates configuration parameters in DiskHalo and Binary examples
- Enhances README documentation with instructions for visualizing results
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| Nbody/plotOrbit.py | New visualization script for plotting multiple disk orbit trajectories from ORBTRACE output |
| Binary/plotOrbit.py | New visualization script for plotting binary star system orbits |
| Nbody/README.md | Added section documenting how to use the plotOrbit.py script |
| Binary/README.md | Enhanced documentation with sections on running examples and viewing results |
| DiskHalo/config.yml | Updated cylinder force parameters (nmaxfid→lmaxfid, added sech2 flag, increased grid resolution) |
| Binary/logpot.yml | Reduced VERBOSE level from 4 to 1 for cleaner output |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+7
to
+10
| Plots two orbital trajectories given a list of 3D positions. | ||
|
|
||
| Parameters: | ||
| positions: A list of 3d particle trajectories (x, y, z) positions for N times both trajectories as an list of M ndarrays of shape (N, 6). |
There was a problem hiding this comment.
The docstring says "Plots two orbital trajectories" but the function actually plots any number of trajectories (as many as are in the positions list). Consider changing to "Plots multiple orbital trajectories" or "Plots orbital trajectories".
Suggested change
| Plots two orbital trajectories given a list of 3D positions. | |
| Parameters: | |
| positions: A list of 3d particle trajectories (x, y, z) positions for N times both trajectories as an list of M ndarrays of shape (N, 6). | |
| Plots orbital trajectories given a list of 3D positions. | |
| Parameters: | |
| positions: A list of 3d particle trajectories (x, y, z) positions for N times, as a list of M ndarrays of shape (N, 6). |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
michael-petersen
approved these changes
Dec 10, 2025
Member
michael-petersen
left a comment
michael-petersen
left a comment
There was a problem hiding this comment.
All changes look straightforward -- happy to merge this in.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Might be nice to add more visualization scripts moving forward.