Adds a getAccel() member to BiorthBasis
#146
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
May 21, 2025 11:42
2 tasks
…ansform for FlatDisk and CBDisk
Member
Author
|
Adrian and Lehman have checked this while developing their Gala interface. So I think this is safe to merge at this point. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This addresses the first of #136: a member function that returns the acceleration only, rather than the full field array with density and potential.
Details
getAccel(x, y, z)base class toBiorthBasisgetAccel()for every derived basis:Spherical,Cylindrical,FlatDisk,CBDisk,Cube, andSlabgetAccel()routines reimplement stripped down versions of the basis evaluations for speedSpherical(which includesSphericalSLby inheritance) andCylindricalhave been checked directly against theirgetFields()version.To Do
Test the remaining acceleration routines:
FlatDiskCBDiskCubeSlabNote
This PR implements new features so is based off
develnotmain, as per our branch policy discussions.