Skip to content

[WIP] [WIP] Address feedback to apply coefficient rotation change in computeAccel() calls#221

Merged
michael-petersen merged 5 commits into
develfrom
copilot/wip-address-feedback-apply-coefficient-rotation-ch
May 29, 2026
Merged

[WIP] [WIP] Address feedback to apply coefficient rotation change in computeAccel() calls#221
michael-petersen merged 5 commits into
develfrom
copilot/wip-address-feedback-apply-coefficient-rotation-ch

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 27, 2026

Thanks for the feedback on #220. I've created this new PR, which merges into #220, to address your comment. I will work on the changes and keep this PR's description up to date as I make progress.

Original PR: #220
Triggering review: #220 (comment)

@copilot This suggestion is good; please applying the same coefficient rotation change to all computeAccel() call sites in expui/BiorthBasis.cc as a new PR against devel.

Copy link
Copy Markdown
Member

@The9Cat The9Cat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me: Copilot seems to have changed all computeAccel implementations.

@michael-petersen
Copy link
Copy Markdown
Member

@copilot resolve the merge conflicts in this pull request

@michael-petersen
Copy link
Copy Markdown
Member

@copilot can you take the failure from the CI run and suggest an edit?

Copy link
Copy Markdown
Contributor Author

Copilot AI commented May 28, 2026

@copilot can you take the failure from the CI run and suggest an edit?

I addressed the CI failure in commit a935940 by removing the duplicate Eigen::Vector3d pos declaration in Cube::computeAccel() (expui/BiorthBasis.cc), which resolved the redeclaration compile error from the failing Build and Test run.

@The9Cat
Copy link
Copy Markdown
Member

The9Cat commented May 28, 2026

Huh, that's odd. I pulled devel earlier, built successfully, and ran the full cmake suite.

@michael-petersen michael-petersen marked this pull request as ready for review May 29, 2026 06:07
Copilot AI review requested due to automatic review settings May 29, 2026 06:07
Copy link
Copy Markdown
Member

@michael-petersen michael-petersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All computeAccel calls have been updated!

@michael-petersen michael-petersen merged commit 3aa536b into devel May 29, 2026
4 of 5 checks passed
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants