Skip to content

Missing global key#223

Merged
michael-petersen merged 2 commits into
develfrom
missingGlobalKey
May 29, 2026
Merged

Missing global key#223
michael-petersen merged 2 commits into
develfrom
missingGlobalKey

Conversation

@The9Cat
Copy link
Copy Markdown
Member

@The9Cat The9Cat commented May 29, 2026

Issue

Wanted to use adjust max_mindt for testing and found that it was not in the global key list.

Fix

Added the key. One-liner.

@The9Cat The9Cat requested a review from Copilot May 29, 2026 16:13
@The9Cat The9Cat added the bug Something isn't working label May 29, 2026
@The9Cat The9Cat changed the base branch from main to devel May 29, 2026 16:14
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR goes well beyond the stated “missing global key” fix: in addition to adding maxMindt to the global key whitelist, it introduces a QuickDigest5 submodule and MD5-based cache consistency metadata, expands cylindrical basis configuration/modeling options, adds new deprojection/MD5 test programs, and bumps the project version to 7.10.3.

Changes:

  • Add maxMindt to global_valid_keys (to match existing YAML parsing support).
  • Add QuickDigest5 (as a submodule) and integrate MD5 hashing for Python module consistency checks in cache metadata.
  • Add multiple new test utilities under utils/Test (EmpDeproj/Deprojector/CubicSpline + MD5 test) and update build files accordingly.

Reviewed changes

Copilot reviewed 1 out of 1 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
utils/Test/testmd5.cc New standalone MD5 verification test (QuickDigest5 vs system md5sum).
utils/Test/testEmpDeproj.cc New empirical deprojection validation driver comparing EmpDeproj vs Deprojector.
utils/Test/testEmp.cc New EmpDeproj driver with optional embedded-Python density function support.
utils/Test/testDeproject.cc New Deprojector validation driver for analytic surface-density profiles.
utils/Test/EmpDeproj.H New EmpDeproj test-side header.
utils/Test/EmpDeproj.cc New EmpDeproj implementation for test utilities.
utils/Test/Deprojector.H New Deprojector test-side header.
utils/Test/Deprojector.cc New Deprojector implementation (grid build + Abel inversion).
utils/Test/CubicSpline.H New minimal cubic spline used by test Deprojector.
utils/Test/CubicSpline.cc New cubic spline implementation used by test Deprojector.
utils/Test/CMakeLists.txt Adds new test executables and QuickDigest5 include path; links pybind11 embed for testEmp.
utils/ICs/initial.cc Refactors EmpCylSL model selection to use EmpModelMap; minor comment/format changes.
utils/ICs/check_coefs2.cc Refactors EmpCylSL model selection to use EmpModelMap.
utils/ICs/check_coefs.cc Refactors EmpCylSL model selection to use EmpModelMap.
src/global_key_set.H Adds maxMindt to global key whitelist (but currently missing a comma).
src/Cylinder.H Extends Cylinder configuration with disk/deprojection model types and related parameters.
src/Cylinder.cc Adds DiskType/dmodel parsing, deprojection model selection, cache metadata checks, and metadata persistence.
src/CMakeLists.txt Adds QuickDigest5 include directory for src build.
pyEXP/BasisWrappers.cc Docstring updates; changes override handling; adds field-eval methods documentation/bindings.
include/SLGridMP2.H Switch CUDA includes to quoted includes.
include/exputils.H Adds declaration for get_md5sum.
include/EmpCylSL.H Introduces AbelType, bumps cache Version to 1.1, switches EmpModel to enum class, adds mapping tables.
include/DiskModels.H Adds Toomre disk model class.
include/cudaParticle.cuH Normalizes includes; moves mode-line comment.
include/cudaMappingConstants.cuH Normalizes includes; moves mode-line comment.
include/BiorthCyl.H Normalizes CUDA includes; removes duplicated include blocks.
include/BiorthCube.H Normalizes CUDA includes; removes duplicated include blocks.
exputil/getmd5sum.cc New helper to compute MD5 via system md5sum (used for test/verification).
exputil/EmpCylSL.cc Implements new Abel inversion modes and switches EmpModel usage to enum class.
exputil/CMakeLists.txt Adds getmd5sum + QuickDigest5 source and include paths to exputil build.
expui/CMakeLists.txt Installs CUDA headers in public header file set.
expui/BiorthBasis.H Adds deprojection type support and additional Python projection config members.
expui/BiorthBasis.cc Adds md5-based cache metadata checks + writes metadata; adjusts accel frame transform handling; deprecations.
expui/BasisFactory.H Adds Origin-frame field evaluation APIs and documentation.
expui/BasisFactory.cc Implements Origin-frame field evaluation methods.
doc/exp.cfg.breathe Bumps documented version number to 7.10.3.
doc/exp.cfg Bumps documented version number to 7.10.3.
CMakeLists.txt Bumps project version to 7.10.3; adds QuickDigest5 include directory.
.gitmodules Adds QuickDigest5 submodule definition.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/global_key_set.H Outdated
Comment thread src/global_key_set.H Outdated
Comment thread src/global_key_set.H Outdated
Comment thread src/global_key_set.H Outdated
Comment thread src/global_key_set.H Outdated
Comment thread src/global_key_set.H Outdated
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@michael-petersen michael-petersen merged commit 761f303 into devel May 29, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants