Conversation
jtcoolen
force-pushed
the
julian@dsl-update
branch
14 times, most recently
from
8fdc005 to
f0e245a
Compare
jtcoolen
force-pushed
the
julian@dsl-update
branch
14 times, most recently
from
a7d422c to
cbff56d
Compare
|
|
||
| zokrates: | ||
| image: ghcr.io/eyblockchain/zokrates-worker-updated:latest | ||
| image: ghcr.io/jtcoolen/zokrates-worker-api:latest |
There was a problem hiding this comment.
We will need to push a new image under the EYBlockchain domain
| //generate the circuit files from the newly created circuit AST: | ||
| logger.verbose('Generating files from the .zok AST...'); | ||
| const circuitFileData = codeGenerator(newAST); | ||
| let circuitFileData = codeGenerator(newAST, state); |
There was a problem hiding this comment.
Ideally, is there a reason the information needs to be stored in state as opposed to inside the circuit AST?
There was a problem hiding this comment.
Well one could annotate functions' nodes in the AST with the whether they are called from other functions, but this requires one full AST traversal to identify which functions are internal function calls. Storing the internal function calls during one AST traversal in a global state is convenient.
There was a problem hiding this comment.
The purpose of the state is to store information for use later in the AST traversal in toCircuitVisitor. The purpose of the newly generated circuit AST is to be used in the toCircuit code generation. I don't think it should affect the number of AST traversals, because it could be done where it currently is done, inside the toCircuitVisitor.
There was a problem hiding this comment.
While I reckon we could store the info of whether a particular function is used in an internal function call in the function's node, this approach of storing this info in the global state structure is convenient.
There was a problem hiding this comment.
Removed the usage of state in toCircuitVisitor but couldn't in toCircuit because we need to store the wrapper functions during the code generation to later introduce the new .zok files for the wrapper functions. Instead of passing the state to the codeGenerator function used global variables.
|
|
||
| zokrates2: | ||
| image: ghcr.io/eyblockchain/zokrates-worker-updated:latest | ||
| image: ghcr.io/jtcoolen/zokrates-worker-api:latest |
There was a problem hiding this comment.
We should make sure to push the new version before we merge.
There was a problem hiding this comment.
Cleaned up the branch https://github.com/EYBlockchain/zokrates-worker/tree/julian/swati/starlight which is used to build the Docker image
jtcoolen
force-pushed
the
julian@dsl-update
branch
17 times, most recently
from
9e50680 to
df45a6c
Compare
|
🎉 This PR is included in version 1.9.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
2 participants
This PR fixes #388