Conversation
Summary of ChangesHello @janishorsts, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly refactors the project's dependency management by removing several unused packages and their transitive dependencies. This cleanup contributes to a smaller project footprint and improved maintainability. Additionally, the build process has been modernized with updated Node.js and npm versions, and the Earthfile now leverages "npm ci" for more consistent builds. A new Renovate configuration has also been added to enhance automated version management for Earthfile specific declarations. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request refactors the project to remove unused dependencies and improve the Earthly build process. The changes in package.json and package-lock.json remove several dependencies like @actions/github and node-fetch. The Earthfile is updated to use npm ci for more reliable builds, and the file copying logic is refactored for better caching and clarity. I've suggested a further simplification for the lint target in Earthfile to make it more efficient and maintainable. Overall, these are good improvements.
➖ Are we earthbuild yet?No change in "earthly" occurrences 📈 Overall Progress
Keep up the great work migrating from Earthly to Earthbuild! 🚀 💡 Tips for finding more occurrencesRun locally to see detailed breakdown: ./.github/scripts/count-earthly.shNote that the goal is not to reach 0. |
npm cito install dependencies for deterministic outcomes instead ofnpm installnpm