Skip to content

refactor: remove unused deps#67

Merged
gilescope merged 4 commits intomainfrom
refactor-remove-unused-deps
Oct 2, 2025
Merged

refactor: remove unused deps#67
gilescope merged 4 commits intomainfrom
refactor-remove-unused-deps

Conversation

@janishorsts
Copy link

@janishorsts janishorsts commented Oct 1, 2025

  • removed unused deps
  • added optional dep @rollup/rollup-linux-x64-musl
  • use npm ci to install dependencies for deterministic outcomes instead of npm install
  • let renovate update the npm

@janishorsts janishorsts self-assigned this Oct 1, 2025
@janishorsts janishorsts requested a review from a team as a code owner October 1, 2025 10:46
@janishorsts janishorsts requested review from gilescope and removed request for a team October 1, 2025 10:46
@gemini-code-assist
Copy link

Summary of Changes

Hello @janishorsts, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly refactors the project's dependency management by removing several unused packages and their transitive dependencies. This cleanup contributes to a smaller project footprint and improved maintainability. Additionally, the build process has been modernized with updated Node.js and npm versions, and the Earthfile now leverages "npm ci" for more consistent builds. A new Renovate configuration has also been added to enhance automated version management for Earthfile specific declarations.

Highlights

  • Dependency Removal: Eliminated several unused direct dependencies, including "@actions/github", "make-dir", "mkdirp-promise", and "node-fetch", along with their associated transitive dependencies.
  • Build Process Refinement: Updated the Earthfile to use a newer Node.js base image and "npm ci" for more reliable and reproducible dependency installations, and streamlined tsconfig.json copying across build stages.
  • Renovate Configuration: Introduced a custom Renovate manager to automatically track and update version arguments and environment variables within the Earthfile.
  • License File Updates: Cleaned up and updated the license files to accurately reflect the current set of project dependencies after the removals.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the project to remove unused dependencies and improve the Earthly build process. The changes in package.json and package-lock.json remove several dependencies like @actions/github and node-fetch. The Earthfile is updated to use npm ci for more reliable builds, and the file copying logic is refactored for better caching and clarity. I've suggested a further simplification for the lint target in Earthfile to make it more efficient and maintainable. Overall, these are good improvements.

@github-actions
Copy link

github-actions bot commented Oct 1, 2025

➖ Are we earthbuild yet?

No change in "earthly" occurrences

📈 Overall Progress

Branch Total Count
main 92
This PR 92
Difference +0

Keep up the great work migrating from Earthly to Earthbuild! 🚀

💡 Tips for finding more occurrences

Run locally to see detailed breakdown:

./.github/scripts/count-earthly.sh

Note that the goal is not to reach 0.
There is anticipated to be at least some occurences of earthly in the source code due to backwards compatibility with config files and language constructs.

Copy link

@gilescope gilescope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gilescope gilescope merged commit 42cbe00 into main Oct 2, 2025
28 of 31 checks passed
@gilescope gilescope deleted the refactor-remove-unused-deps branch October 2, 2025 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants