feat: Add Renovate comments for dependency detection and add local te…#220
feat: Add Renovate comments for dependency detection and add local te…#220kmannislands merged 2 commits intomainfrom
Conversation
➖ Are we earthbuild yet?No change in "earthly" occurrences 📈 Overall Progress
Keep up the great work migrating from Earthly to Earthbuild! 🚀 💡 Tips for finding more occurrencesRun locally to see detailed breakdown: ./.github/scripts/count-earthly.shNote that the goal is not to reach 0. |
Summary of ChangesHello @danielschlegel, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly upgrades the repository's dependency management capabilities by integrating Renovate more deeply across various file types and technologies. The changes aim to ensure more comprehensive and automated tracking of dependencies, from Docker images and Earthly build steps to language-specific packages. Additionally, it provides robust local testing tools, empowering developers to validate Renovate configurations efficiently before deployment, thereby streamlining the update process and reducing potential issues. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request significantly enhances dependency management automation by expanding Renovate's capabilities. It introduces new managers, custom patterns for better dependency detection in various file types, and adds local testing scripts which are a great addition for validating configuration changes. The changes are well-structured. I've provided a few suggestions to simplify the new test scripts and to address a couple of redundancies and potential conflicts in the Renovate configuration to ensure it's as clean and efficient as possible.
gilescope
left a comment
There was a problem hiding this comment.
Good step in the right direction. Once the comments are resolved this is good to land.
bfb3ae9 to
8a07334
Compare
|
@kmannislands i removed the scripts and rebased on main. |
🔧 Major Configuration Changes
.github/renovate.json5- Comprehensive Renovate EnhancementEnabled multiple package managers:
github-actions)Enhanced Docker/Dockerfile management:
Dockerfile*anddocker-compose*.ymlAdded 5 new custom managers:
Restructured package rules:
dockerfile-dependencies- Groups all Dockerfile updates (monthly)examples-and-docs-dependencies- Groups example/docs updates (monthly)nodejs-examples-dependencies- Groups Node.js dependenciespython-examples-dependencies- Groups Python dependenciesruby-examples-dependencies- Groups Ruby dependenciesgithub-actions- Groups GitHub Actions updatesshell-script-dependencies- Groups shell script dependenciesdocker-compose-dependencies- Groups Docker Compose updatesmise-tool-versions- Groups development tool versions🏷️ Renovate Comments Added
Infrastructure Files
.devcontainer/Dockerfile- Added renovate comment for Microsoft devcontainer base imageEarthfile- Added comment for earthly/lib dependencybuildkitd/docker-auto-install.sh- Added 3 renovate comments for docker-compose installations across different architecturesExample Projects
examples/go/docker-compose.yml- Fixed image reference formatexamples/ruby-on-rails/Earthfile- Added renovate commentexamples/zig/Earthfile- Added renovate commentTest Infrastructure (11 files)
Added renovate comments to various test Dockerfiles and docker-compose files:
scripts/tests/interactive-debugger/docker-compose/rot13/Dockerfiletests/autoskip/Dockerfiletests/dind-auto-install/docker-compose.ymltests/docker/Dockerfiletests/docker2earth/Dockerfile1tests/docker2earth/Dockerfile2tests/dockerfile/Dockerfiletests/local/with-docker-compose-local-reg/docker-compose.ymltests/local/with-docker-compose-local/docker-compose.ymltests/with-docker-compose/docker-compose.yml📝 New Testing Infrastructure
scripts/test-renovate-simple.sh(173 lines)scripts/test-renovate-full.sh(147 lines)scripts/README-renovate-testing.md(121 lines)