chore(lint): enable embeddedstructfieldcheck

[janishorsts]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @janishorsts, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request adjusts the project's linting configuration by removing the embeddedstructfieldcheck linter from the .golangci.yaml file. Concurrently, it applies the formatting style typically enforced by this linter, adding blank lines after embedded struct fields in various Go files to improve code consistency and readability. A specific nolint directive was introduced for one struct where fieldalignment considerations take precedence, ensuring a balanced approach to code quality and structure.

Highlights

• Linter Configuration Update: The embeddedstructfieldcheck linter has been removed from the .golangci.yaml configuration, indicating a refinement in the project's linting rules.
• Code Formatting Consistency: Blank lines have been introduced after embedded struct fields in numerous Go files to enhance readability and ensure a consistent code formatting style across the codebase.
• Specific Linter Exception: A nolint:embeddedstructfieldcheck directive was added to the Config struct in states/image/image.go. This explicitly bypasses the linter for this particular struct, prioritizing fieldalignment over the embedded struct field check.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[github-actions]

➖ Are we earthbuild yet?

No change in "earthly" occurrences

📈 Overall Progress

Branch	Total Count
main	5734
This PR	5734
Difference	+0

---

Keep up the great work migrating from Earthly to Earthbuild! 🚀

💡 Tips for finding more occurrences

Run locally to see detailed breakdown:

./.github/scripts/count-earthly.sh

Note that the goal is not to reach 0.
There is anticipated to be at least some occurences of earthly in the source code due to backwards compatibility with config files and language constructs.

[gemini-code-assist]

Code Review

The pull request title indicates the intention to enable the embeddedstructfieldcheck linter. While several code changes (reordering struct fields) appear to address warnings from this linter, the .golangci.yaml configuration file shows embeddedstructfieldcheck being removed from the active linters list. This creates a direct contradiction between the PR's stated goal and its implementation in the linter configuration. Please clarify the intended action regarding this linter.