ci: fix bash array quoting + shellcheck annotations#576
Conversation
Signed-off-by: Giles Cope <gilescope@gmail.com>
➖ Are we earthbuild yet?No change in "earthly" occurrences 📈 Overall Progress
Keep up the great work migrating from Earthly to Earthbuild! 🚀 💡 Tips for finding more occurrencesRun locally to see detailed breakdown: ./.github/scripts/count-earthly.shNote that the goal is not to reach 0. |
There was a problem hiding this comment.
Code Review
This pull request adds comments and shellcheck disable directives to not-a-unit-test.sh to suppress linter warnings. The reviewer identified a potential issue where leaving $testarg unquoted could cause word-splitting bugs if $testname contains spaces, and suggested using an if/else block to conditionally pass the -run argument with proper quoting.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
… comment Signed-off-by: Giles Cope <gilescope@gmail.com>
Extracted from #442 (the buildkit upgrade) — genuine shell-correctness fixes, independent of the bump.
reusable-misc-tests-1.yml— fix bash array handling in the warm-up loop:pids[i]=$!, iterate"${pids[@]}",wait "$pid"(was${pids[*]}/wait $pid), and add--no-outputto the parallel hello-world invocations.not-a-unit-test.sh— add# shellcheck disableannotations for two pre-existing findings the file surfaces once linted: SC2016 on the intentional single-quotedsedtoken, and SC2086/SC2154 on thego test $testarg $pkgnameline (both are env-injected by the Earthfile+unit-testARGs and deliberately unquoted so emptytestargadds no arg and multi-patternpkgnameword-splits).Excludes the OOM-motivated bits from the same files (remote-cache retry loop,
GO_TEST_PARALLELISMcap) — those stay in #442.