Skip to content

ci: fix bash array quoting + shellcheck annotations#576

Merged
janishorsts merged 3 commits into
mainfrom
giles-ci-shell-fixes
Jun 16, 2026
Merged

ci: fix bash array quoting + shellcheck annotations#576
janishorsts merged 3 commits into
mainfrom
giles-ci-shell-fixes

Conversation

@gilescope

Copy link
Copy Markdown

Extracted from #442 (the buildkit upgrade) — genuine shell-correctness fixes, independent of the bump.

  • reusable-misc-tests-1.yml — fix bash array handling in the warm-up loop: pids[i]=$!, iterate "${pids[@]}", wait "$pid" (was ${pids[*]} / wait $pid), and add --no-output to the parallel hello-world invocations.
  • not-a-unit-test.sh — add # shellcheck disable annotations for two pre-existing findings the file surfaces once linted: SC2016 on the intentional single-quoted sed token, and SC2086/SC2154 on the go test $testarg $pkgname line (both are env-injected by the Earthfile +unit-test ARGs and deliberately unquoted so empty testarg adds no arg and multi-pattern pkgname word-splits).

Excludes the OOM-motivated bits from the same files (remote-cache retry loop, GO_TEST_PARALLELISM cap) — those stay in #442.

Signed-off-by: Giles Cope <gilescope@gmail.com>
@github-actions

github-actions Bot commented Jun 15, 2026

Copy link
Copy Markdown

➖ Are we earthbuild yet?

No change in "earthly" occurrences

📈 Overall Progress

Branch Total Count
main 5314
This PR 5314
Difference +0

Keep up the great work migrating from Earthly to Earthbuild! 🚀

💡 Tips for finding more occurrences

Run locally to see detailed breakdown:

./.github/scripts/count-earthly.sh

Note that the goal is not to reach 0.
There is anticipated to be at least some occurences of earthly in the source code due to backwards compatibility with config files and language constructs.

@gilescope gilescope added the ai-assisted Authored with AI assistance label Jun 15, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds comments and shellcheck disable directives to not-a-unit-test.sh to suppress linter warnings. The reviewer identified a potential issue where leaving $testarg unquoted could cause word-splitting bugs if $testname contains spaces, and suggested using an if/else block to conditionally pass the -run argument with proper quoting.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread not-a-unit-test.sh Outdated
@gilescope gilescope mentioned this pull request Jun 15, 2026
10 tasks
@gilescope gilescope marked this pull request as ready for review June 15, 2026 05:42
@gilescope gilescope requested a review from a team as a code owner June 15, 2026 05:42
@gilescope gilescope requested review from janishorsts and removed request for a team June 15, 2026 05:42
… comment

Signed-off-by: Giles Cope <gilescope@gmail.com>
@janishorsts janishorsts enabled auto-merge (squash) June 16, 2026 15:49
@janishorsts janishorsts disabled auto-merge June 16, 2026 18:00
@janishorsts janishorsts merged commit 6ea3244 into main Jun 16, 2026
89 checks passed
@janishorsts janishorsts deleted the giles-ci-shell-fixes branch June 16, 2026 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-assisted Authored with AI assistance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants