Skip to content

PH5 fixes#30

Merged
gillian-earthscope merged 19 commits intomasterfrom
lk-ph5-fixes
Apr 22, 2025
Merged

PH5 fixes#30
gillian-earthscope merged 19 commits intomasterfrom
lk-ph5-fixes

Conversation

@laura-iris
Copy link
Collaborator

Updated the code to:

  1. Handle the IRISPH5 service name when setting dataselect and station values
  2. Update the PSD metric to create an evalResp object when the station type is ph5ws
  3. Update getSpectra() to use the station -url and -type when creating an evalResp object via web services, to better handle ph5 data.

@laura-iris laura-iris self-assigned this Apr 17, 2025
@gillian-earthscope
Copy link
Contributor

The README.md for resp_dir (line 346) should be updated with ph5ws/evalresp information.

@gillian-earthscope
Copy link
Contributor

gillian-earthscope commented Apr 18, 2025

This README.md example is failing:
./run_ispaq.py -M psd_corrected,pdf -S II.KAPI.00.BHZ --starttime 2013-01-05 --endtime 2013-01-08 --dataselect_url ./test_data --station_url ./test_data/II.KAPI_station.xml --output csv --psd_dir ./test_out/PSDs --pdf_dir ./test_out/PDFs --pdf_type plot --pdf_interval aggregated --log-level DEBUG

2025-04-18 15:33:09 - INFO - Running evalresp
2025-04-18 15:33:09 - ERROR - 'RS4' object has no attribute 'snclId'
2025-04-18 15:33:09 - WARNING - "PSD" metric calculation failed for II.KAPI.00.BHZ

@gillian-earthscope
Copy link
Contributor

gillian-earthscope commented Apr 18, 2025

I think at this point there is no station_type (for the above issue). If I add a default station_type=None, then this is the output:
2025-04-18 15:37:03 - INFO - Running evalresp
2025-04-18 15:37:03 - DEBUG - calling /Users/gilliansharer/git_temp/ispaq/test_data/II.KAPI_station.xml - None evalresp web service
2025-04-18 15:37:03 - ERROR - 'RS4' object has no attribute 'snclId'

@gillian-earthscope
Copy link
Contributor

Just one more comment, I don't think this log message below rises to the level of INFO. It's a debug level message and is redundant with the debug logging in the utils.py getSpectra. I suggest removing it.

line 106 PSD_metrics.py logger.info('Running evalresp')

@laura-iris
Copy link
Collaborator Author

Okay, I believe that all comments have been addressed at this point. Let me know if you've found anything else and I'll get to them, otherwise I think we're good to merge.

@gillian-earthscope gillian-earthscope self-requested a review April 22, 2025 16:07
@gillian-earthscope gillian-earthscope merged commit d3130fe into master Apr 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants