Fix some of memory leaked by NVHPC v24.9+#43
Merged
gdicker1 merged 5 commits intoEarthWorksOrg:ew-developfrom Jun 25, 2025
Merged
Fix some of memory leaked by NVHPC v24.9+#43gdicker1 merged 5 commits intoEarthWorksOrg:ew-developfrom
gdicker1 merged 5 commits intoEarthWorksOrg:ew-developfrom
Conversation
added 4 commits
June 18, 2025 12:29
This will enable some fixes to memory leaked by NVHPC v24.9 and newer.
Changes to array assignment in coords_1d.F90 that ensures an intermediate allocate isn't used for lines like 'coords%ifc = ifc' (both are real(r8) arrays).
Credit to John Dennis (dennis@ucar.edu,johnmauff) for this fix for a memory leak with NVHPC v24.9 and newer.
gdicker1
added
bug
Author
|
Sub-PRs for this work: |
Author
|
@johnmauff, no review is really required. This is more to notify or let you review if you'd like. |
Get upstream developments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reduce the memory lost during runs with the nvhpc/24.9 or nvhpc/24.11 stacks on Derecho. This includes making array assignment explicit (
tmp1(:,:) = tmp2(:,:)instead oftmp1 = tmp2) and freeing memory at the end ofradiation_tendfrom rrtmgp.Changes found by @johnmauff