Skip to content

Claude/fix all the things 016m gv g ahqs puhs4 f st xr p jt#20

Merged
ananthpai1998 merged 3 commits intomainfrom
claude/fix-all-the-things-016mGvGAhqsPuhs4FStXrPJt
Nov 17, 2025
Merged

Claude/fix all the things 016m gv g ahqs puhs4 f st xr p jt#20
ananthpai1998 merged 3 commits intomainfrom
claude/fix-all-the-things-016mGvGAhqsPuhs4FStXrPJt

Conversation

@ananthpai1998
Copy link
Copy Markdown
Collaborator

Pull Request

Description

Type of Change

  • 🚀 Feature - New functionality
  • 🐛 Bug fix - Fixes an issue
  • 🗃️ Database migration - Schema changes
  • 📝 Documentation - Updates to docs
  • ⚡ Performance improvement
  • 🎨 UI/UX - Visual or interaction changes
  • ♻️ Refactor - Code restructuring without functional changes
  • 🧪 Test - Adding or updating tests
  • 🔧 Chore - Maintenance tasks

Database Changes

  • ✅ No database changes
  • 📊 Schema changes - Migration file: lib/db/migrations/XXXX_migration_name.sql
  • 🔄 Data migration required
  • 🔒 RLS policy changes
  • 📈 Index additions/modifications

Migration Details (if applicable)

Tables affected:

Migration file:

  • lib/db/migrations/XXXX_migration_name.sql

Backward compatible:

  • Yes
  • No (breaking change - requires coordination)

Rollback script included:

  • Yes
  • No
  • N/A

Impact on existing data:

Verification queries:

Testing

  • ✅ Tested locally
  • ✅ All existing tests pass
  • ✅ New tests added
  • ✅ Manual testing performed
  • ✅ Tested with production-like data

Test Coverage

Screenshots/Videos (if UI changes)

Breaking Changes

  • ⚠️ This PR includes breaking changes

If yes, describe:

Performance Impact

  • No performance impact expected
  • Performance improvements expected
  • Potential performance impact (explain below)

Details:

Security Considerations

  • No security impact
  • Security improvement
  • Requires security review

Details:

Dependencies

New dependencies:

Updated dependencies:

Checklist

  • 📖 Code follows project style guidelines (run pnpm lint)
  • 🔍 Self-reviewed the code
  • 💬 Commented complex/unclear code
  • 📚 Updated relevant documentation (README, API docs, etc.)
  • 🧪 Added/updated tests for new functionality
  • 🔒 Verified RLS policies work correctly (if DB changes)
  • ⚡ Added indexes for new foreign keys (if DB changes)
  • 🏷️ Updated TypeScript types/interfaces
  • ♿ Considered accessibility (if UI changes)
  • 📱 Tested on mobile/responsive (if UI changes)
  • 🌐 No hardcoded strings (using i18n if applicable)

Related Issues

Closes #
Related to #

Additional Context

Deployment Notes

  • Requires environment variable changes
  • Requires manual migration by Super Admin
  • Requires coordination with other PRs
  • Should be deployed during low-traffic hours

Special instructions:


For Reviewers

Focus areas:
1.
2.

Testing instructions:
1.
2.


Super Admin Checklist (for DB migrations)

  • Reviewed migration script syntax
  • Verified backward compatibility
  • Tested on staging/local Supabase
  • Verified rollback script works
  • No data loss risk
  • Performance impact assessed (indexes added?)
  • RLS policies correct and secure
  • Ready to apply to production

- Add explicit boolean type annotations to Switch onCheckedChange handlers across agent config components
- Install missing @radix-ui packages (avatar, checkbox, collapsible, dropdown-menu, scroll-area, separator, switch)
- Install missing uuid package for activity logger

Fixed type errors in:
- components/admin/agents/chat-model/chat-model-agent-config.tsx
- components/admin/agents/document/document-agent-config.tsx
- components/admin/agents/git-mcp/git-mcp-agent-config.tsx
- components/admin/agents/mermaid/mermaid-agent-config.tsx
- components/admin/agents/provider-tools/provider-tools-agent-config.tsx
- components/admin/agents/python/python-agent-config.tsx
- components/admin/logging-dashboard.tsx

Build now passes successfully.
Removed unnecessary files and dependencies that were not being used:

Files removed:
- playwright.config.ts - No tests exist in the project
- test-tool-config.js - Empty/unused configuration file
- instrumentation.ts - OpenTelemetry not enabled in Next.js config
- package-lock.json - Project uses pnpm, not npm
- tsconfig.tsbuildinfo - Build artifact, should not be committed

Dependencies removed:
- @playwright/test - No tests to run
- @vercel/otel - Only used in removed instrumentation.ts
- @opentelemetry/api - Only needed for instrumentation
- @opentelemetry/api-logs - Only needed for instrumentation

Scripts removed:
- "test" script - No test files exist

Files kept (they ARE being used):
- drizzle.config.ts - Database migrations actively used in build
- biome.jsonc - Linting configuration (used by ultracite)
- middleware.ts - Next.js middleware
- next.config.ts, tsconfig.json, postcss.config.mjs - Core configs

Build verified successful after cleanup.
The Vercel deployment is failing due to stale build cache from recently
removed dependencies (@playwright/test, @vercel/otel, etc.).

Changes:
- Add VERCEL_BUILD_FIX.md with instructions to clear Vercel build cache
- Update .gitignore to include tsconfig.tsbuildinfo (prevent future commits)
- Remove Playwright references from .gitignore (no longer used)

Local builds pass successfully - this is purely a Vercel cache issue.

To fix on Vercel:
1. Go to project Settings → General
2. Clear Build Cache
3. Redeploy

The file can be deleted after the Vercel issue is resolved.
@ananthpai1998 ananthpai1998 merged commit d5fab10 into main Nov 17, 2025
1 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants