Account for CEF update on gmod main branch#152
Conversation
We finally have CEF on main, so this check doesn't make much sense anymore
|
Is this confirmed? |
|
From changelog: |
|
Can you confirm in-game please |
Media player/google works on main for example
|
|
Alright well in that case this PR needs to be more thorough. There are other places that are essentially useless now such as the CEF detection and the |
|
Just remembered that CEF is still not updated on Linux and still needs CEFCodecFix to work. Is this critical for you? |
|
Well in that case we just need to update |
|
The |
|
This also concerns macos btw |
Both of these platforms do not support building CEF for 32bit anymore from what I gathered from the giant thread on garrysmod-requests |
Actually you're right, I didnt think of this earlier but main branch only works serverside on UNIX based platforms. So yeah this is not a problem after all I guess, because you can't play without CEFCodecFix anyway. Unless you have a custom main menu in lua only but in this case I think we can safely assume this person knows what theyre doing anyway. |
|
@Astralcircle is this done or are you still working on it? |
|
It's done for me, but if you need something then i will do it |
* Remove x64 warning We finally have CEF on main, so this check doesn't make much sense anymore * Replace checks
* Remove x64 warning We finally have CEF on main, so this check doesn't make much sense anymore * Replace checks
3 participants
We finally have CEF on main, so this check doesn't make much sense anymore