Conversation
cal-pratt
requested review from
CalvinGregory and
ConnorWhalen
and removed request for
CalvinGregory
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Today I spent some time ghostbusting on the ROV. This PR has two notable bug fixes// gotchas to avoid.
Bug 1: Maestro channel values
I thought that setting the maestro channel to negative 1 would be a good option for unused channels, however, sending a -1 to the maestro causes it to freak out and not work properly. Values are now set to random unused channel (this should be less dumb)
Bug 2: JavaFX scheduler NPE
Refs findings in and fixes #309
Update the video decoder
The video decoder now uses an rxjava
SyncOnSubscribeobject to handle its threading. This overall makes controlling the decoder easier and avoids managing non final instance fields and all the fun that goes along with null checking.Update the sensor view
Finally decide to remove some of the useless values in the sensor view. We only have one external pressure sensor, one internal pressure (IMU) and one internal temperature (IMU). The
ExternalPressureValue[A|B]has been replaced withExternalPressureValue, similarlyDepthValue[A|B]withDepthValue