homework-4 #5
homework-4 #5
Conversation
|
|
||
| console.log('Категория:', key); | ||
|
|
||
| for(let i = 0; i < category[key].length; i++){ |
There was a problem hiding this comment.
I think you have to define category[key] as a variable, that variable used widely and what does it mean not really clear.
For example, take a look on line 51, what does category[key][i] refer to ? what abstraction inside?
|
|
||
| function fizzBuzz(num) { | ||
| let someRes; | ||
| if(num % 3 == 0 && num % 5 == 0){ |
There was a problem hiding this comment.
There was approach for FizzBuzz in class I guess you can apply it here
| function newArr(arr){ | ||
| let newArray = []; | ||
| for(let i = 0; i < arr.length; i++){ | ||
| newArray.push( typeof arr[i]); |
There was a problem hiding this comment.
arr[i] - probably better to give some name to that construction
| function solution(arr) { | ||
| for (let key in arr) { | ||
| let arrKey = arr[key]; | ||
| if (Number.isNaN(arrKey.age)) { |
There was a problem hiding this comment.
isNaN enough, no need refer to "Number"
|
|
||
| function solution(arr) { | ||
| for (let key in arr) { | ||
| let arrKey = arr[key]; |
There was a problem hiding this comment.
arr[key] - is element, not an a arrKey :)
|
|
||
|
|
||
| function solution(arr) { | ||
| for (let key in arr) { |
There was a problem hiding this comment.
It's better to use for loop instead of for-in.
for-in much slower than for loop
| function unknownAge(arr) { | ||
| let newArr = []; | ||
| for (let key in arr) { | ||
| let arrKey = arr[key]; |
There was a problem hiding this comment.
the arrKey name could be improved, it's just simple an a element for example
| return newArr; | ||
| } | ||
| console.log(solution(array)); | ||
|
|
No description provided.