Skip to content

Conversation

Cameron-Low
Copy link
Contributor

Apparently trivialstruggles to deal with P /\ Q /\ R => P /\ R when either P or R are sufficiently complex (e.g. contains an existential).
This should close #775.

@alleystoughton
Copy link
Member

Works for my example.

@namasikanam
Copy link
Collaborator

It also works for my minimal working example. Furthermore, it works for my original complicated example, too! Thank you so much!

@namasikanam
Copy link
Collaborator

I'm trying to understand what's going on in this PR. Why are you talking about trivial @Cameron-Low ? I'm completely lost.

@Cameron-Low
Copy link
Contributor Author

Cameron-Low commented Aug 14, 2025

I'm trying to understand what's going on in this PR. Why are you talking about trivial @Cameron-Low ? I'm completely lost.

see #EasyCrypt: questions & features > match: cannot clear c that is/are used in the conclusion @ 💬l

@strub
Copy link
Member

strub commented Aug 14, 2025

@Cameron-Low Is trivial still called by the tactic? I cannot see where it is replaced by your ad-hoc tactic in the code.

@Cameron-Low
Copy link
Contributor Author

@Cameron-Low Is trivial still called by the tactic? I cannot see where it is replaced by your ad-hoc tactic in the code.

Sorry, I had pushed the wrong version of the fix... It's all there now.

@Cameron-Low Cameron-Low requested a review from fdupress August 15, 2025 13:12
Copy link
Member

@fdupress fdupress left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Made a comment phrased as a question, but it can be safely addressed by dismissal if that is the most appropriate way of addressing it.

@Cameron-Low Cameron-Low merged commit e4eb5d3 into main Aug 20, 2025
28 of 30 checks passed
@Cameron-Low Cameron-Low deleted the fix-775 branch August 20, 2025 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

spurious Hoare logic match error connected to simplification hints

5 participants