Add hook for site cleanup #164
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Riddhesh Sanghvi <riddheshsanghvi96@gmail.com>
This was referenced Oct 10, 2018
rahulsprajapati
approved these changes
Oct 11, 2018
rahulsprajapati
suggested changes
Oct 11, 2018
| } | ||
| } | ||
|
|
||
| \EE::do_hook( 'site_cleanup', $site_url ); |
Contributor
There was a problem hiding this comment.
@mrrobot47 Please add some comment above this hook. Like: What it can be use for and when and what's $site_url is use for.
Member
Author
There was a problem hiding this comment.
Added. Please check if this much info is sufficient.
Contributor
There was a problem hiding this comment.
oops, I just meant the short description. What this hook is about.
/**
* Execute before site db data cleanup and after site services cleanup.
* Note: This can be use to cleanup site data added by any package command.
*
* @param string $site_url Url of site which data is cleanup.
*/Add this.
Ps.: You can check hook commenting in WP for ref https://github.com/WordPress/WordPress/blob/8efab48edeb348db9399410b5ede28785ad25357/wp-admin/admin-header.php
Signed-off-by: Riddhesh Sanghvi <riddheshsanghvi96@gmail.com>
Signed-off-by: Riddhesh Sanghvi <riddheshsanghvi96@gmail.com>
mrrobot47
force-pushed
the
update/site_cleanup
branch
from
81f4150 to
0aa2261
Compare
rahulsprajapati
approved these changes
Oct 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #147
Signed-off-by: Riddhesh Sanghvi riddheshsanghvi96@gmail.com