Skip to content

Add hook for site cleanup #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 15, 2018
Merged

Add hook for site cleanup #164

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2dfcdc5
Add hook for site cleanup
mrrobot47 Oct 10, 2018
7ce303c
Update comment explaining hook
mrrobot47 Oct 11, 2018
0aa2261
Update hook description
mrrobot47 Oct 15, 2018
83a9e65
Merge branch 'develop' into update/site_cleanup
mrrobot47 Oct 15, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/helper/class-ee-site.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,6 +223,13 @@ protected function delete_site( $level, $site_url, $site_fs_path, $db_data = []
}
}

/**
* Execute before site db data cleanup and after site services cleanup.
* Note: This can be use to cleanup site data added by any package command.
*
* @param string $site_url Url of site which data is cleanup.
*/
\EE::do_hook( 'site_cleanup', $site_url );
Copy link
Contributor

@rahulsprajapati rahulsprajapati Oct 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mrrobot47 Please add some comment above this hook. Like: What it can be use for and when and what's $site_url is use for.

Copy link
Member Author

@mrrobot47 mrrobot47 Oct 11, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added. Please check if this much info is sufficient.

Copy link
Contributor

@rahulsprajapati rahulsprajapati Oct 15, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, I just meant the short description. What this hook is about.

	/**
	 * Execute before site db data cleanup and after site services cleanup.
	 * Note: This can be use to cleanup site data added by any package command.
	 *
	 * @param string $site_url Url of site which data is cleanup.
	 */

Add this.

Ps.: You can check hook commenting in WP for ref https://github.com/WordPress/WordPress/blob/8efab48edeb348db9399410b5ede28785ad25357/wp-admin/admin-header.php


if ( $level > 4 ) {
if ( $this->site_data['site_ssl'] ) {
Expand Down