Update docker volume mounting #188
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Riddhesh Sanghvi <riddheshsanghvi96@gmail.com>
Signed-off-by: Riddhesh Sanghvi <riddheshsanghvi96@gmail.com>
Signed-off-by: Riddhesh Sanghvi <riddheshsanghvi96@gmail.com>
…tings Signed-off-by: Riddhesh Sanghvi <riddheshsanghvi96@gmail.com>
Signed-off-by: Riddhesh Sanghvi <riddheshsanghvi96@gmail.com>
Signed-off-by: Riddhesh Sanghvi <riddheshsanghvi96@gmail.com>
mbtamuli
suggested changes
Oct 23, 2018
src/helper/class-ee-site.php
Outdated
| $volume_prefix = \EE\Site\Utils\get_site_prefix( $site_url ); | ||
| $finder = new Finder(); | ||
| $finder->in( $volumes_dir ); | ||
| $volumes_to_delete = $finder->directories()->name( $volume_prefix . '*' ); |
Contributor
There was a problem hiding this comment.
Finding volume prefix and deleting them is unnecessary. Please create volumes using labels.
Example
docker volume create \
--label "org.label-schema.vendor=EasyEngine" \
--label "io.easyengine.site=one.test" \
onetest_htdocs
Contributor
There was a problem hiding this comment.
This command will list the volumes with specific label
docker volume ls --filter="label=org.label-schema.vendor=EasyEngine" --filter="label=io.easyengine.site=one.test"
Adding the -q flag will only display the name
docker volume ls --filter="label=org.label-schema.vendor=EasyEngine" --filter="label=io.easyengine.site=one.test" -q
Contributor
There was a problem hiding this comment.
Docker Root Dir - docker info 2> /dev/null | awk '/Docker Root Dir/ {print $4}'
Signed-off-by: Riddhesh Sanghvi <riddheshsanghvi96@gmail.com>
Signed-off-by: Riddhesh Sanghvi <riddheshsanghvi96@gmail.com>
Signed-off-by: Riddhesh Sanghvi <riddheshsanghvi96@gmail.com>
Signed-off-by: Riddhesh Sanghvi <riddheshsanghvi96@gmail.com>
Signed-off-by: Riddhesh Sanghvi <riddheshsanghvi96@gmail.com>
This was referenced Oct 23, 2018
mbtamuli
suggested changes
Oct 24, 2018
Contributor
mbtamuli
left a comment
mbtamuli
left a comment
There was a problem hiding this comment.
Looks good except a few minor changes.
Co-Authored-By: mrrobot47 <riddheshsanghvi96@gmail.com>
Co-Authored-By: mrrobot47 <riddheshsanghvi96@gmail.com>
Signed-off-by: Riddhesh Sanghvi <riddheshsanghvi96@gmail.com>
rahulsprajapati
previously approved these changes
Oct 24, 2018
mbtamuli
previously approved these changes
Oct 24, 2018
Signed-off-by: Riddhesh Sanghvi <riddheshsanghvi96@gmail.com>
mrrobot47
dismissed stale reviews from mbtamuli and rahulsprajapati
via
db30b68
rahulsprajapati
approved these changes
Oct 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #187
Depends on EasyEngine/easyengine#1259
Depends on EasyEngine/dockerfiles#40