Conversation
stephenjwatkins
commented
Jan 9, 2026
| } | ||
|
|
||
| .focused, | ||
| [data-focus-visible="true"] { |
Member
Author
There was a problem hiding this comment.
this was applying globally
stephenjwatkins
commented
Jan 9, 2026
Comment on lines
+13
to
+15
| margin-bottom: design-token("space.0.5"); | ||
| // Defer to inner Text for line-height | ||
| line-height: 0; |
Member
Author
There was a problem hiding this comment.
these were creating extra space around the labels
stephenjwatkins
commented
Jan 9, 2026
| const color = hasError ? "danger" : undefined; | ||
| return ( | ||
| <label {...labelProps} className={classNames(styles.label)}> | ||
| <AriaLabel {...labelProps} className={classNames(styles.label)}> |
Member
Author
There was a problem hiding this comment.
take advantage of react aria's Label contexting
stephenjwatkins
commented
Jan 9, 2026
Comment on lines
+67
to
+68
| // TODO: Look into why this test is flaking after upgrading React Aria to 3.45.0 | ||
| it.skip("should support SearchNav.Selector being controlled", async () => { |
Member
Author
There was a problem hiding this comment.
weird test quirk i couldn't figure out. functionality appears to still work
ralexmatthews
approved these changes
Jan 9, 2026
Contributor
ralexmatthews
left a comment
ralexmatthews
left a comment
There was a problem hiding this comment.
Niiiiice work. Looks good to me 👍
Comment on lines
+16
to
+21
| style={({ defaultStyle }) => ({ | ||
| background: ` | ||
| ${defaultStyle.background}, | ||
| repeating-conic-gradient(#CCC 0% 25%, white 0% 50%) 50% / 16px 16px | ||
| `, | ||
| })} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Changes
ColorPickerColorPickerInputFieldreact-aria*packages✅ Checklist
Easy UI has certain UX standards that must be met. In general, non-trivial changes should meet the following criteria:
Strikethroughany items that are not applicable to this pull request.