Conversation
Justintime50
requested changes
Mar 10, 2022
…w `PropertyMissing` error if missing
…n C# code can compile correctly for other language environments - Add VB and FSharp compile tests to GitHub CI
Contributor
Author
|
@Justintime50 per our discussions, I have added an extra test for the Visual Basic test suite. There's no need to recreate the entire test suite for the F# and Visual Basic variants. There are two tests in the Visual Basic test suite:
In fact, the test suite actually running is largely unnecessary. Just by the nature of the project (featuring formerly-problematic code) compiling, we can confirm that our C# code can be imported successfully into a Visual Basic or F# environment. |
…I key, will produce a ClientNotConfigured error. But as long as it doesn't produce any other errors, functionality is working as expected.
jchen293
approved these changes
Mar 14, 2022
Create methodsCreate methods
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per #151 , Visual Basic cannot tell the difference between a static and non-static version of the same method signature. This is an issue because we have both static and non-static
Createmethods in a handful of our classes.The non-static methods, however, are for creating/recreating an object in case its
idis blank, which logically does not make much sense. Why are we checking, i.e. when callingmyOrder.Buy()whethermyOrderexists? Of course it does.The methods were likely implemented for a single-altered structure, accounting for if the
idwas somehow blank/not returned by the API. There are better ways to handle this. For now, I have removed theidcheck, but if it is truly necessary, we should have an exception thrown, rather have the library attempt to regenerate the object. In that case, we can rollback part of these changes and add a newResourceNotCreatedexpection.By removing these non-static
Createmethods, there should be no more ambiguity for Visual Basic.