Makefile and build scripts #289
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Split build.bat into multiple smaller Batch scripts (allow to be run individually or via make) - Fix compile tests in F# and VB unit tests
Justintime50
reviewed
Jul 1, 2022
Member
Justintime50
left a comment
Justintime50
left a comment
There was a problem hiding this comment.
Windows doesn't have access to make out of the box whereas many unix systems do. You'll want to install make on Windows and ensure these commands are cross compatible, otherwise there isn't much worth in adding these in: https://community.chocolatey.org/packages/make
I'll defer reviewing till Windows support has been confirmed as I'm sure there are a couple tweaks left.
- Fix quotes for Windows
- Makefile step to check Batch scripts - Checking Batch scripts added as CI step (won't fail)
- Makefile step still exists for manual run
Justintime50
reviewed
Jul 6, 2022
Member
Justintime50
left a comment
Justintime50
left a comment
There was a problem hiding this comment.
All is fine; however, I'd prefer that check_scripts is renamed to something like lint_scripts so it is more easier for searching, understanding, and uses the same language we are accustomed to.
Justintime50
approved these changes
Jul 6, 2022
jchen293
approved these changes
Jul 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Testing
Pull Request Type
Please select the option(s) that are relevant to this PR.