LaserShipV2 extra required parameters // umitguner #334
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
the pull request related to easypost support ticket number "321557" |
Contributor
|
@umitgnr Thanks for the PR! You will need to remove the |
Member
|
Please also place the other options into the listed sorted instead of at the end of the list |
umitgnr
commented
Sep 22, 2022
Contributor
Author
umitgnr
left a comment
umitgnr
left a comment
There was a problem hiding this comment.
LaserShipV2 changes fixed and sorted // umitguner
Contributor
Author
|
Thank you for feedback, it is updated and sorted.
Regards,
Justin Hammond ***@***.***>, 22 Eyl 2022 Per, 16:59 tarihinde
şunu yazdı:
… Please also place the other options into the listed sorted instead of at
the end of the list
—
Reply to this email directly, view it on GitHub
<#334 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAQMZ2WTAAOYP47IF2WNA4LV7RQ3XANCNFSM6AAAAAAQSYILSI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
nwithan8
approved these changes
Sep 22, 2022
jchen293
approved these changes
Sep 22, 2022
| public string special_rates_eligibility { get; set; } | ||
| [JsonProperty("suppress_etd")] | ||
| public bool? suppress_etd { get; set; } | ||
|
|
Contributor
There was a problem hiding this comment.
This line should be preserved
Justintime50
approved these changes
Sep 22, 2022
Member
Justintime50
left a comment
Justintime50
left a comment
There was a problem hiding this comment.
LaserShip definitely requires these fields. Thanks for adding.
Member
|
Your changes have been released via |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
LaserShipV2 extra required parameters added to the Options.cs class
Testing
Extra three required parameter added for LaserShipV2 carrier.
The below documentation explains the why these parameters needed and test conditions and results.
https://support.easypost.com/hc/en-us/articles/360062036932-Lasership-V2-Guide
Pull Request Type