fix: param nesting for report creation requests (closes #658)#659
Merged
Justintime50 merged 1 commit intomasterfrom Apr 28, 2026
Merged
fix: param nesting for report creation requests (closes #658)#659Justintime50 merged 1 commit intomasterfrom
Justintime50 merged 1 commit intomasterfrom
Conversation
sroomberg-ep
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The params were not nested at the root level for report creation which is required so params like
columnsandadditional_columnswere not accepted at the API. This PR corrects the nesting to put them at the root which should fix these params when generating reports. (closes #658)Additionally, un-nested all cassette files. Years ago we tested this lib against multiple frameworks at once which required multiple sets of cassettes which is no longer the case. The cassettes nested in a
netfolder is no longer helpful, moving them up a level.Finally, cleaned up a similar problem with webhooks that lingered from years earlier where to avoid collisions, we had to differentiate the urls used in webhook generation based on net version in use. Removed that as a part of this too.
Testing
Re-recorded all affected cassettes (otherwise cassettes just moved location).
Pull Request Type
Please select the option(s) that are relevant to this PR.