Skip to content

fix: param nesting for report creation requests (closes #658)#659

Merged
Justintime50 merged 1 commit intomasterfrom
report_param_nesting
Apr 28, 2026
Merged

fix: param nesting for report creation requests (closes #658)#659
Justintime50 merged 1 commit intomasterfrom
report_param_nesting

Conversation

@Justintime50
Copy link
Copy Markdown
Member

@Justintime50 Justintime50 commented Apr 28, 2026

Description

The params were not nested at the root level for report creation which is required so params like columns and additional_columns were not accepted at the API. This PR corrects the nesting to put them at the root which should fix these params when generating reports. (closes #658)

Additionally, un-nested all cassette files. Years ago we tested this lib against multiple frameworks at once which required multiple sets of cassettes which is no longer the case. The cassettes nested in a net folder is no longer helpful, moving them up a level.

Finally, cleaned up a similar problem with webhooks that lingered from years earlier where to avoid collisions, we had to differentiate the urls used in webhook generation based on net version in use. Removed that as a part of this too.

Testing

Re-recorded all affected cassettes (otherwise cassettes just moved location).

Pull Request Type

Please select the option(s) that are relevant to this PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement (fixing a typo, updating readme, renaming a variable name, etc)

@Justintime50 Justintime50 requested review from a team as code owners April 28, 2026 18:20
@Justintime50 Justintime50 merged commit 3385cbb into master Apr 28, 2026
18 checks passed
@Justintime50 Justintime50 deleted the report_param_nesting branch April 28, 2026 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Can't request column carrier_account_id in report via the api

2 participants