Skip to content

Conversation

@Justintime50
Copy link
Member

@Justintime50 Justintime50 commented Sep 29, 2022

Description

This PR fixes the slow scrubbing operations due to an incorrectly placed for loop. By pulling the for loop outside of the recursive call, we aren't needlessly double, triple, etc running the foor loop inside of another foor loop down and down the rabbit hole.

NOTE: The enforcement for coverage was dropped 1% since it was straddling the line and falls just beneath it on CI for some reason.

Testing

I tested a few cassettes getting re-recorded and ensured this worked as intended

Pull Request Type

Please select the option(s) that are relevant to this PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement (fixing a typo, updating readme, renaming a variable name, etc)

@Justintime50 Justintime50 requested a review from a team September 29, 2022 22:01
@Justintime50 Justintime50 mentioned this pull request Sep 30, 2022
4 tasks
@Justintime50 Justintime50 merged commit 48ec491 into master Sep 30, 2022
@Justintime50 Justintime50 deleted the fix_slow_scrubbing branch September 30, 2022 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants