Skip to content

Conversation

@Justintime50
Copy link
Member

@Justintime50 Justintime50 commented Sep 30, 2022

Description

Adds a test utility that checks for expired cassettes on each run and throws errors if cassettes must be re-recorded due to old age to ensure the data is always up-to-date within a half year.

Testing

I set the days to ~40 and errors were thrown, setting it to 180 has the suite pass

Pull Request Type

Please select the option(s) that are relevant to this PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement (fixing a typo, updating readme, renaming a variable name, etc)

@Justintime50 Justintime50 requested a review from a team September 30, 2022 06:19
@Justintime50 Justintime50 marked this pull request as draft September 30, 2022 06:20
@Justintime50
Copy link
Member Author

Blocked until #232 is merged

@Justintime50 Justintime50 force-pushed the expire_cassettes branch 2 times, most recently from baf51b4 to 1109717 Compare September 30, 2022 17:30
@Justintime50 Justintime50 marked this pull request as ready for review September 30, 2022 17:31
nwithan8
nwithan8 previously approved these changes Sep 30, 2022
@nwithan8 nwithan8 self-requested a review September 30, 2022 21:36
@Justintime50 Justintime50 merged commit 6d0357d into master Oct 1, 2022
@Justintime50 Justintime50 deleted the expire_cassettes branch October 1, 2022 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants