Add math optimization flags#364
Merged
carstene1ns merged 1 commit intoEasyRPG:masterfrom Apr 19, 2020
Merged
Conversation
ghost
approved these changes
Apr 11, 2020
ghost
added
the
Member
|
Do we even have enough math operations here that this matters? |
Member
|
Right. There is only one cmath include in lsd_reader.cpp and it looks unused. (leftover from old timestamp code maybe) |
Contributor
Author
|
Practically we don't need it here. It just added it to keep in line with Player or in case we do add some floating point math later. Up to you guys if we should merge or drop. |
carstene1ns
approved these changes
Apr 19, 2020
Member
carstene1ns
left a comment
carstene1ns
left a comment
There was a problem hiding this comment.
I would say pull this in, it does not have any drawbacks and can potentially speed things up, if ever needed.
Ghabry
approved these changes
Apr 19, 2020
Member
Ghabry
left a comment
Ghabry
left a comment
There was a problem hiding this comment.
Okay, then I will also not block this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.