ci: rewrite build workflows#2089
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the Core GitHub Actions workflow to switch the FreeBSD build from a FreeBSD VM-based build to a Zig-based cross-compilation approach (via cargo-zigbuild), and adjusts some workflow formatting.
Changes:
- Removes most target entries from the build matrix, leaving only
x86_64-unknown-freebsd. - Adds
mlugg/setup-zigand installscargo-zigbuildto support Zig-based cross compilation. - Replaces the FreeBSD VM action step with a direct
cargo zigbuild-based build on Ubuntu.
Comments suppressed due to low confidence (2)
.github/workflows/core.yml:66
- The build matrix now only includes the FreeBSD target. Downstream jobs in this workflow (e.g.,
magisk_build) and any releases that expect Linux/macOS/Windows artifacts will no longer have those artifacts available, which will cause this workflow to fail or publish incomplete releases. If the intent is to switch how targets are built (via zigbuild) rather than to drop platforms, re-add the removed targets to the matrix (or update downstream consumers to match the reduced artifact set).
strategy:
fail-fast: true
matrix:
include:
- TARGET: x86_64-unknown-freebsd
OS: ubuntu-22.04
ARTIFACT_NAME: freebsd-13.2-x86_64
BSD_VERSION: 13.2
.github/workflows/core.yml:66
BSD_VERSIONis still defined in the matrix but is no longer used after removing the FreeBSD VM action inputs. Consider removing it (or using it to parameterize the target environment) to avoid confusion about which FreeBSD version the artifact is built against.
- TARGET: x86_64-unknown-freebsd
OS: ubuntu-22.04
ARTIFACT_NAME: freebsd-13.2-x86_64
BSD_VERSION: 13.2
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
pb apt install rust musl-tools remove rustflags p p p c c
libappindicator3 musl-tools gui dep gui
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 15 out of 16 changed files in this pull request and generated 8 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
features rearrange matrix rustflags in config.toml config.toml: linker c p c
core compress core.yml
core: use actions-rust-lang/setup-rust-toolchain@v1
gui: arm os armos gui collect dll
|
upx的行为不要改了,都是踩坑踩出来的,不是报毒就是用不了 |
|
Windows Defender 确实报毒,riscv64 和 web, web-embed 的压缩我用虚拟机测一下试试 |
|
qemu 跑了 |
|
mips 应该跑不了吧? |
|
而且之前我遇到的情况是我用 qemu 能跑起来,一上板子就跪了 |
mips 原本就有压缩,新增的 target 只有 riscv64
那这有点麻烦……现在 upx 的修改是 version 更新到 5.1.1,增加了 web 和 web-embed 的压缩,并且给 riscv64 也压缩,如果 core 和 cli 之前没问题,那 web 和 web-embed 应该也没问题? |
更新 mobile.yml mobile.yml mobile: no gui
|
upx/upx#895 |
|
windows 报毒还是很头疼的,要不把 windows 的 upx 关掉吧,win 上感觉也没啥必要压缩 |
|
我上一个提交已经关了 |
|
我申请了一个 RISCV Builder 的 GitHub App,我先在我自己的 fork 上试试 一直卡在 |
重写 CI 构建配置文件
freebsd 的构建消耗时间减半;GUI 的 windows arm 目标构建用时减少一些;使用 zigbuild 进行交叉编译的目标用时均增加一分钟;其他 target 基本不变