Circular Imports and Typing#155
Merged
Merged
Conversation
|
|
||
| Unofficial Python API for TIDAL music streaming service. | ||
|
|
||
| Requires Python 3.7 or higher. |
Collaborator
There was a problem hiding this comment.
This might change very soon.. We should remember to update it to the latest supported version.
Collaborator
|
How did you trigger circular imports? Would like to reproduce. |
Author
Edit: Initial version missed entering the venv |
Collaborator
|
Oh rats that should never have happened, I really need to get the tests running again. I'd prefer to avoid some of these long |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Definitely a seagull PR.
I was unable to utilize this library due to #148 so I tried using HEAD, but had problems with circular imports.
Along the way, also added types I was interested in for what I was doing.
Works For Me™️