Ecwid 116235 api client change#373
Merged
ZimuZhengLightspeed merged 2 commits intomasterfrom Mar 11, 2024
Merged
Conversation
ZimuZhengLightspeed
force-pushed
the
ECWID-116235_ApiClient-change
branch
from
dd434c3 to
a185637
Compare
ZimuZhengLightspeed
changed the title
istvan-szabo-lightspeed
approved these changes
Mar 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to allow alt text in variation image, the alt property need to be added in FetchedVariation and UpdatedVariation. Also the converter for convert FetchedVariation to UpdatedVariation. After this, the ecwid repo need to update with the new variation and add the mapping logic for the alt.
Reuse FetchedAlt and UpdatedAlt as alt text type.