Skip to content

ECWID-148639 Product reviews: added new design settings #434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Alexis2004 merged 2 commits into from
Sep 10, 2024
Merged

ECWID-148639 Product reviews: added new design settings #434

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0f651f4
Product reviews: added new design settings
kitty-ecwid Sep 9, 2024
2cb1d53
Fixed StoreProfileTest - replaced 'ru' country mention
kitty-ecwid Sep 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions src/main/kotlin/com/ecwid/apiclient/v3/dto/profile/result/FetchedStoreProfile.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -607,6 +607,9 @@ data class FetchedStoreProfile(
@JsonFieldName("product_details_position_product_sku")
val productDetailsPositionProductSku: Int? = null,

@JsonFieldName("product_details_position_review_section")
val productDetailsPositionReviewSection: Int? = null,

@JsonFieldName("product_details_position_save_for_later")
val productDetailsPositionSaveForLater: Int? = null,

Expand Down Expand Up @@ -679,6 +682,15 @@ data class FetchedStoreProfile(
@JsonFieldName("product_details_show_qty")
val productDetailsShowQty: Boolean? = null,

@JsonFieldName("product_details_show_rating_section")
val productDetailsShowRatingSection: Boolean? = null,

@JsonFieldName("product_details_show_reviews_section")
val productDetailsShowReviewsSection: Boolean? = null,

@JsonFieldName("product_details_show_reviews_section_in_one_card_view")
val productDetailsShowReviewsSectionInOneCardView: Boolean? = null,

@JsonFieldName("product_details_show_sale_price")
val productDetailsShowSalePrice: Boolean? = null,

Expand Down Expand Up @@ -769,6 +781,9 @@ data class FetchedStoreProfile(
@JsonFieldName("product_list_price_behavior")
val productListPriceBehaviour: String? = null,

@JsonFieldName("product_list_rating_section_behavior")
val productListRatingSectionBehavior: String? = null,

@JsonFieldName("product_list_sku_behavior")
val productListSKUBehaviour: String? = null,

Expand All @@ -793,6 +808,15 @@ data class FetchedStoreProfile(
@JsonFieldName("product_list_show_product_images")
val productListShowProductImages: Boolean? = null,

@JsonFieldName("product_list_show_rating_in_one_star")
val productListShowRatingInOneStar: Boolean? = null,

@JsonFieldName("product_list_show_rating_number_in_five_stars_view")
val productListShowRatingNumberInFiveStarsView: Boolean? = null,

@JsonFieldName("product_list_show_reviews_count_in_five_stars_view")
val productListShowReviewsCountInFiveStarsView: Boolean? = null,

@JsonFieldName("show_signin_link")
val productListShowSignInLink: Boolean? = null,

Expand Down
8 changes: 4 additions & 4 deletions src/test/kotlin/com/ecwid/apiclient/v3/entity/StoreProfileTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,10 +84,10 @@ class StoreProfileTest : BaseEntityTest() {
email = "email@example.com",
street = "street",
city = "city",
countryCode = "RU",
countryCode = "GE",
postalCode = "postalCode",
phone = "phone",
stateOrProvinceCode = "73"
stateOrProvinceCode = "TB"
),
formatsAndUnits = UpdatedStoreProfile.FormatsAndUnits(
currency = "currency",
Expand Down Expand Up @@ -148,8 +148,8 @@ class StoreProfileTest : BaseEntityTest() {
UpdatedStoreProfile.Zone(
id = "zoneId",
name = "Zone name",
countryCodes = listOf("RU", "UA"),
stateOrProvinceCodes = listOf("RU-73", "RU-77"),
countryCodes = listOf("GE", "UA"),
stateOrProvinceCodes = listOf("GE-AJ", "GE-TB"),
postCodes = listOf("123456", "654321")
)
),
Expand Down
8 changes: 8 additions & 0 deletions ...test/kotlin/com/ecwid/apiclient/v3/rule/nullablepropertyrules/FetchedStoreProfileRules.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,7 @@ val fetchedStoreProfileNullablePropertyRules: List<NullablePropertyRule<*, *>> =
AllowNullable(FetchedStoreProfile.DesignSettings::productDetailsPositionProductPrice),
AllowNullable(FetchedStoreProfile.DesignSettings::productDetailsPositionProductLoyalty),
AllowNullable(FetchedStoreProfile.DesignSettings::productDetailsPositionProductSku),
AllowNullable(FetchedStoreProfile.DesignSettings::productDetailsPositionReviewSection),
AllowNullable(FetchedStoreProfile.DesignSettings::productDetailsPositionSaveForLater),
AllowNullable(FetchedStoreProfile.DesignSettings::productDetailsPositionShareButtons),
AllowNullable(FetchedStoreProfile.DesignSettings::productDetailsPositionSubtitle),
Expand All @@ -117,6 +118,9 @@ val fetchedStoreProfileNullablePropertyRules: List<NullablePropertyRule<*, *>> =
AllowNullable(FetchedStoreProfile.DesignSettings::productDetailsShowProductLoyalty),
AllowNullable(FetchedStoreProfile.DesignSettings::productDetailsShowProductSku),
AllowNullable(FetchedStoreProfile.DesignSettings::productDetailsShowQty),
AllowNullable(FetchedStoreProfile.DesignSettings::productDetailsShowRatingSection),
AllowNullable(FetchedStoreProfile.DesignSettings::productDetailsShowReviewsSection),
AllowNullable(FetchedStoreProfile.DesignSettings::productDetailsShowReviewsSectionInOneCardView),
AllowNullable(FetchedStoreProfile.DesignSettings::productDetailsShowSalePrice),
AllowNullable(FetchedStoreProfile.DesignSettings::productDetailsShowSaveForLater),
AllowNullable(FetchedStoreProfile.DesignSettings::productDetailsShowShareButtons),
Expand Down Expand Up @@ -147,6 +151,7 @@ val fetchedStoreProfileNullablePropertyRules: List<NullablePropertyRule<*, *>> =
AllowNullable(FetchedStoreProfile.DesignSettings::productListImageSize),
AllowNullable(FetchedStoreProfile.DesignSettings::productListNameBehaviour),
AllowNullable(FetchedStoreProfile.DesignSettings::productListPriceBehaviour),
AllowNullable(FetchedStoreProfile.DesignSettings::productListRatingSectionBehavior),
AllowNullable(FetchedStoreProfile.DesignSettings::productListSKUBehaviour),
AllowNullable(FetchedStoreProfile.DesignSettings::productListShowAdditionalImage),
AllowNullable(FetchedStoreProfile.DesignSettings::productListShowBreadcrumbs),
Expand All @@ -155,6 +160,9 @@ val fetchedStoreProfileNullablePropertyRules: List<NullablePropertyRule<*, *>> =
AllowNullable(FetchedStoreProfile.DesignSettings::productListShowOnSaleLabel),
AllowNullable(FetchedStoreProfile.DesignSettings::productListShowPayWhatYouWantLabel),
AllowNullable(FetchedStoreProfile.DesignSettings::productListShowProductImages),
AllowNullable(FetchedStoreProfile.DesignSettings::productListShowRatingInOneStar),
AllowNullable(FetchedStoreProfile.DesignSettings::productListShowRatingNumberInFiveStarsView),
AllowNullable(FetchedStoreProfile.DesignSettings::productListShowReviewsCountInFiveStarsView),
AllowNullable(FetchedStoreProfile.DesignSettings::productListShowSignInLink),
AllowNullable(FetchedStoreProfile.DesignSettings::productListShowSoldOutLabel),
AllowNullable(FetchedStoreProfile.DesignSettings::productListShowSortViewAsOptions),
Expand Down