Skip to content

ECOM-17360: Orders/Cart: added shippingLimit field to DiscountInfo classes #558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hanna-ecwid wants to merge 2 commits into
base: master
Choose a base branch
from
Open

ECOM-17360: Orders/Cart: added shippingLimit field to DiscountInfo classes #558

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4985857
ECOM-17360: Orders/Cart: added shippingLimit field to DiscountInfo cl…
hanna-ecwid Jun 4, 2026
f6e66d0
ECOM-17360: Updated nullable and non-updatable property rules to incl…
hanna-ecwid Jun 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/main/kotlin/com/ecwid/apiclient/v3/dto/cart/request/OrderForCalculate.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,12 @@ data class OrderForCalculate(
val applicationLimit: DiscountCouponApplicationLimit? = null,
val creationDate: Date? = null,
val orderCount: Int? = null,
val catalogLimit: DiscountCouponCatalogLimit? = null
val catalogLimit: DiscountCouponCatalogLimit? = null,
val shippingLimit: DiscountCouponShippingLimit? = null
)

data class DiscountCouponShippingLimit(
val shippingMethods: List<String>? = null
)

data class DiscountCouponCatalogLimit(
Expand Down
7 changes: 6 additions & 1 deletion src/main/kotlin/com/ecwid/apiclient/v3/dto/cart/result/CalculateOrderDetailsResult.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,12 @@ data class CalculateOrderDetailsResult(
val applicationLimit: DiscountCouponApplicationLimit? = null,
val creationDate: Date? = null,
val orderCount: Int? = null,
val catalogLimit: DiscountCouponCatalogLimit? = null
val catalogLimit: DiscountCouponCatalogLimit? = null,
val shippingLimit: DiscountCouponShippingLimit? = null
)

data class DiscountCouponShippingLimit(
val shippingMethods: List<String>? = null
)

data class DiscountCouponCatalogLimit(
Expand Down
7 changes: 6 additions & 1 deletion src/main/kotlin/com/ecwid/apiclient/v3/dto/order/result/FetchedOrder.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,12 @@ data class FetchedOrder(
val updateDate: Date? = null,
val orderCount: Int? = null, // TODO Figure out how to test
val catalogLimit: DiscountCouponCatalogLimit? = null, // TODO Figure out how to test
val applicationLimit: DiscountCouponApplicationLimit? = null // TODO Add to docs?
val applicationLimit: DiscountCouponApplicationLimit? = null, // TODO Add to docs?
val shippingLimit: DiscountCouponShippingLimit? = null
)

data class DiscountCouponShippingLimit(
val shippingMethods: List<String>? = null
)

data class DiscountCouponCatalogLimit(
Expand Down
1 change: 1 addition & 0 deletions src/test/kotlin/com/ecwid/apiclient/v3/rule/NonUpdatablePropertyRules.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,6 +202,7 @@ val nonUpdatablePropertyRules: List<NonUpdatablePropertyRule<*, *>> = listOf(
Ignored(FetchedOrder.DiscountCouponInfo::orderCount),
Ignored(FetchedOrder.DiscountCouponInfo::catalogLimit),
Ignored(FetchedOrder.DiscountCouponInfo::applicationLimit),
ReadOnly(FetchedOrder.DiscountCouponInfo::shippingLimit),
ReadOnly(FetchedOrder.BaseOrderItemTax::includeInPrice),
ReadOnly(FetchedOrder.HandlingFeeTax::includeInPrice),
Ignored(FetchedOrder.OrderItem::id),
Expand Down
2 changes: 2 additions & 0 deletions ...lin/com/ecwid/apiclient/v3/rule/nullablepropertyrules/CalculateOrderDetailsResultRules.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,11 @@ val calculateOrderDetailsResultNullablePropertyRules: List<NullablePropertyRule<
IgnoreNullable(CalculateOrderDetailsResult.DiscountCouponInfo::launchDate),
IgnoreNullable(CalculateOrderDetailsResult.DiscountCouponInfo::name),
IgnoreNullable(CalculateOrderDetailsResult.DiscountCouponInfo::orderCount),
AllowNullable(CalculateOrderDetailsResult.DiscountCouponInfo::shippingLimit),
IgnoreNullable(CalculateOrderDetailsResult.DiscountCouponInfo::status),
IgnoreNullable(CalculateOrderDetailsResult.DiscountCouponInfo::totalLimit),
IgnoreNullable(CalculateOrderDetailsResult.DiscountCouponInfo::usesLimit),
AllowNullable(CalculateOrderDetailsResult.DiscountCouponShippingLimit::shippingMethods),
IgnoreNullable(CalculateOrderDetailsResult.DiscountInfo::base),
IgnoreNullable(CalculateOrderDetailsResult.DiscountInfo::description),
IgnoreNullable(CalculateOrderDetailsResult.DiscountInfo::orderTotal),
Expand Down
2 changes: 2 additions & 0 deletions src/test/kotlin/com/ecwid/apiclient/v3/rule/nullablepropertyrules/FetchedOrderRules.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,8 @@ val fetchedOrderNullablePropertyRules: List<NullablePropertyRule<*, *>> = listOf
IgnoreNullable(FetchedOrder.DiscountCouponInfo::totalLimit),
IgnoreNullable(FetchedOrder.DiscountCouponInfo::updateDate),
IgnoreNullable(FetchedOrder.DiscountCouponInfo::usesLimit),
AllowNullable(FetchedOrder.DiscountCouponInfo::shippingLimit),
AllowNullable(FetchedOrder.DiscountCouponShippingLimit::shippingMethods),
IgnoreNullable(FetchedOrder.DiscountInfo::base),
IgnoreNullable(FetchedOrder.DiscountInfo::description),
IgnoreNullable(FetchedOrder.DiscountInfo::orderTotal),
Expand Down
2 changes: 2 additions & 0 deletions src/test/kotlin/com/ecwid/apiclient/v3/rule/nullablepropertyrules/OrderForCalculateRules.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,10 @@ val orderForCalculateNullablePropertyRules: List<NullablePropertyRule<*, *>> = l
IgnoreNullable(OrderForCalculate.DiscountCouponInfo::name),
IgnoreNullable(OrderForCalculate.DiscountCouponInfo::orderCount),
IgnoreNullable(OrderForCalculate.DiscountCouponInfo::status),
AllowNullable(OrderForCalculate.DiscountCouponInfo::shippingLimit),
IgnoreNullable(OrderForCalculate.DiscountCouponInfo::totalLimit),
IgnoreNullable(OrderForCalculate.DiscountCouponInfo::usesLimit),
AllowNullable(OrderForCalculate.DiscountCouponShippingLimit::shippingMethods),
IgnoreNullable(OrderForCalculate.DiscountInfo::base),
IgnoreNullable(OrderForCalculate.DiscountInfo::description),
IgnoreNullable(OrderForCalculate.DiscountInfo::orderTotal),
Expand Down
Loading