fix: resolve hydration error in ThemeProvider#1
Open
EdgarMC100 wants to merge 1 commit intomainfrom
Open
Conversation
…SSR/client initial state The ThemeProvider was causing hydration mismatches because getInitial() returned different values on server vs client: - Server: always returned "dark" (document is undefined) - Client: read from document.documentElement.dataset.theme (could be "light") This mismatch triggered React hydration errors when the server-rendered HTML didn't match the client-rendered output. Solution: - Remove getInitial() function to eliminate the server/client divergence - Initialize theme state with a constant "dark" value on both server and client - Add a mount-only useEffect to sync with the actual DOM theme after hydration completes - Use isInitialized ref guard to prevent cascading renders - Preserves existing theme script functionality to prevent visual flash
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getInitial()function that returned different values on server vs clientProblem
The
ThemeProviderwas causing React hydration errors because:getInitial()always returned"dark"(document is undefined)getInitial()read fromdocument.documentElement.dataset.theme(could be"light")Solution
"dark"on both server and clientuseEffectto sync with actual DOM theme after component mounts (client-only)isInitializedref guard to prevent cascading rendersTest plan
🤖 Generated with Claude Code