Paul/coinrank #88

paullinator · 2022-12-22T07:48:18Z

To see the specific tasks where the Asana app for GitHub is being used, see below:
- https://app.asana.com/0/0/1203527749920640

peachbits · 2023-01-03T02:39:23Z

src/coinrankEngine.ts

+import { setAsync, slackMessage } from './utils/dbUtils'
+import { logger, snooze } from './utils/utils'
+
+const client = createClient()


Don't need to create another client

Makes sense. done

peachbits · 2023-01-03T02:41:16Z

src/coinrankEngine.ts

+const LOOP_DELAY = 45000
+
+export const coinrankEngine = async (): Promise<void> => {
+  await console.log('hello')


Remove testing remnant

peachbits · 2023-01-03T02:50:02Z

src/coinrankEngine.ts

+  try {
+    const lastUpdate = new Date().toISOString()
+    const { uri } = config.providers.coingecko
+    let markets: any = []


Could be typed as CoinrankMarkets instead of any

peachbits · 2023-01-03T09:45:24Z

src/coinrankEngine.ts

+        const marketsPage = asCoingeckoMarkets(reply)
+        markets = [...markets, ...marketsPage]
+      } catch (e) {
+        console.log('ugh')


Let's let the cleaner throw so we don't update the redis list with incomplete data

Makes sense. done

peachbits · 2023-01-03T22:34:32Z

src/exchangeRateRouter.ts

+
+        // Update redis cache
+        const redisData: CoinrankRedis = {
+          markets: data,


This only saves the the sliced data for the requested fiat. Convert everything in the USD list to the selected currency before saving it and returning to the user

I don't understand. All USD market are queried by the engine. The API endpoint only writes non-USD markets after doing the conversion. The converted value is returned to the user and saved in redis.

The data saved to redis is only a subset of the USD data (sliced at 378 and saved in line 392) and once it is saved subsequent requests for the same fiat code will no longer be null at line 361 which skips any conversion functionality.

Instead, take markets in line 377 and convert all of them to the requested fiat -> save to redis -> slice and return to user

understood. makes sense.

peachbits · 2023-01-03T22:38:27Z

src/exchangeRateRouter.ts

+        .send(`Invalid length param: ${length}. Must be between 1-100`)
+      return
+    }
+    const fiatSuffix = fiatCode.split(':')[1]


Nitpick, just use the fiatCode as is for the key. And replace any hardcoded USD/iso:USD value with the default fiat from the config

ok. note there are other hardcoded iso:USD occurences in the file

peachbits · 2023-01-09T20:15:38Z

src/exchangeRateRouter.ts

+
+        // Update redis cache
+        const redisData: CoinrankRedis = {
+          markets: data,


The data saved to redis is only a subset of the USD data (sliced at 378 and saved in line 392) and once it is saved subsequent requests for the same fiat code will no longer be null at line 361 which skips any conversion functionality.

Instead, take markets in line 377 and convert all of them to the requested fiat -> save to redis -> slice and return to user

peachbits · 2023-01-10T09:13:23Z

src/indexEngines.ts

  await setupDatabase(config.couchUri, ratesDbSetup)
-  ratesEngine().catch(e => logger('ratesEnginee failure', e))
-  uidEngine().catch(e => logger('uidEnginee failure', e))
+  // ratesEngine().catch(e => logger('ratesEnginee failure', e))


damn. the whole file change is a turd. how'd that sneak in there. will remove

peachbits · 2023-01-10T09:13:29Z

src/indexEngines.ts

-  ratesEngine().catch(e => logger('ratesEnginee failure', e))
-  uidEngine().catch(e => logger('uidEnginee failure', e))
+  // ratesEngine().catch(e => logger('ratesEnginee failure', e))
+  // uidEngine().catch(e => logger('uidEnginee failure', e))


another turd

paullinator added 2 commits December 20, 2022 23:22

Move db utility functions out of uidEngine

1d2a822

Add node fetch ts types

b0fad94

paullinator requested a review from peachbits December 22, 2022 07:48

paullinator force-pushed the paul/coinrank branch from c8cf9a1 to 18e884c Compare December 22, 2022 08:07

peachbits requested changes Jan 3, 2023

View reviewed changes

paullinator added 2 commits January 4, 2023 22:04

Add coinrank engine to query coingecko every 45s

1686d08

fixup! Add coinrank engine to query coingecko every 45s

b9a37eb

paullinator force-pushed the paul/coinrank branch from 18e884c to ee67703 Compare January 5, 2023 06:04

peachbits requested changes Jan 9, 2023

View reviewed changes

Add coinrank endpoint

d6a8501

paullinator force-pushed the paul/coinrank branch from ee67703 to 157c4ee Compare January 10, 2023 02:29

peachbits requested changes Jan 10, 2023

View reviewed changes

paullinator added 3 commits January 10, 2023 09:58

fixup! Add coinrank endpoint

85f7c15

fixup! Add coinrank endpoint

6f67c17

Remove Nomics

e34ebad

paullinator force-pushed the paul/coinrank branch from 157c4ee to e34ebad Compare January 10, 2023 17:59

peachbits approved these changes Jan 10, 2023

View reviewed changes

paullinator merged commit 8a859da into master Jan 11, 2023

Paul/coinrank #88

Paul/coinrank #88

Uh oh!

Conversation

paullinator commented Dec 22, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

paullinator commented Dec 22, 2022 •

edited

Loading