[UTXO][BTCV] Add Bitcoin Vault cryptocurrency#2733
Open
rrozek555 wants to merge 2 commits intoEdgeApp:developfrom
Open
[UTXO][BTCV] Add Bitcoin Vault cryptocurrency#2733rrozek555 wants to merge 2 commits intoEdgeApp:developfrom
rrozek555 wants to merge 2 commits intoEdgeApp:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
We would like to add BTCV (Bitcoin Vault) cryptocurrency to your wallet app but during preparation of PR we identified a major blocker: your solution does not support WSS (web socket secure) and non-ssl solution is not accepted according to our security standards.
We see currently 2 solutions for this situation as we want to proceed with implementation of BTCV into Edge Wallet app:
Please let us know which option you would like to pursue. We are ready to support you with explanations and guidance within both solutions.
related PR to edge-currency-bitcoin: EdgeApp/edge-currency-bitcoin#259
Kind regards
Jakub Rojek