Merged
Conversation
swansontec
requested changes
Feb 11, 2025
Contributor
swansontec
left a comment
swansontec
left a comment
There was a problem hiding this comment.
The chainCode seems wrong. Also, please drop the first commit, or replace it with the upgrade to edge-currency-accountbased.
| } = { | ||
| abstract: { | ||
| allowZeroTx: true, | ||
| chainCode: 'ETH', |
Contributor
There was a problem hiding this comment.
This is used for FIO. Does FIO support Abstract? If so, is this the code they use?
Contributor
Author
There was a problem hiding this comment.
I don't know if FIO supports Abstract or not. I copied the chainCode from all the other EVM based SpecialCurrencyInfos. Do these other configs need fixing too?
Contributor
There was a problem hiding this comment.
Most likely you have found a bug!
swansontec
approved these changes
Feb 11, 2025
samholmes
force-pushed
the
sam/abstract
branch
from
e0a4c13 to
24985f1
Compare
samholmes
force-pushed
the
sam/abstract
branch
from
24985f1 to
cf3ce5b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneRequirements
If you have made any visual changes to the GUI. Make sure you have: