Sam/conf text #5519
Sam/conf text #5519
Conversation
|
Screenshot? |
src/locales/strings/enUS.json
Outdated
| "fragment_transaction_list_tx_synchronizing": "Syncing...", | ||
| "fragment_transaction_list_confirmation_progress": "%s of %s Confirmations", | ||
| "fragment_transaction_list_unconfirmed_rbf": "Awaiting confirmation, may be cancelled", | ||
| "fragment_transaction_list_unconfirmed_rbf": "Awaiting confirmation; may be cancelled", |
There was a problem hiding this comment.
Also update other applicable languages since this string is already partially localized.
Maybe also change the string key too, because I don't know if crowdin would cache the original string.
samholmes
force-pushed
the
sam/conf-text
branch
from
875fdab to
bfc29a7
Compare
Jon-edge
left a comment
Jon-edge
left a comment
There was a problem hiding this comment.
Approved with optional change
| fragment_transaction_list_tx_synchronizing: 'Syncing...', | ||
| fragment_transaction_list_confirmation_progress: '%s of %s Confirmations', | ||
| fragment_transaction_list_unconfirmed_rbf: 'Awaiting confirmation, may be cancelled', | ||
| fragment_transaction_list_unconfirmed_rbf2: 'Awaiting confirmation; may be cancelled', |
There was a problem hiding this comment.
I generally avoid using a number in the string key, and just use those opportunities to improve the key name. There's almost always an opportunity to improve the key name. Suggest transaction_awaiting_confirmation_rbf since this isn't specific to the tx list, potentially can be reused elsewhere, and is not a fragment. We also don't concatenate string fragments anymore anyway because it doesn't make sense for all locales.
This is saying "Awaiting confirmation and may be cancelled".
samholmes
force-pushed
the
sam/conf-text
branch
from
bfc29a7 to
4526207
Compare
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneRequirements
If you have made any visual changes to the GUI. Make sure you have: