Change Monero privacy label from 'No Privacy' to 'IP is visible'#5965
Change Monero privacy label from 'No Privacy' to 'IP is visible'#5965
Conversation
|
Needs screenshot. Also it looks like the "Network Privacy" and "Monero Server" headers are violating 1rem required margins on the left. |
|
|
So the agent couldn't find any documentation about the 1rem rule perhaps because we haven't solidified it into documentation somewhere. Do you have a prompt for your agents to follow this rule that you mention? If so please do share, if not, then no worries. |
Add SceneContainer wrapper for 1rem margin convention (0.5rem container padding + 0.5rem element margin). Add section headers for token detection and asset settings. Use refresh icon instead of navigation chevron for the detect tokens action to indicate it performs an action rather than navigating to a new scene.
Wrap settings sections in EdgeCard components with section dividers for consistent design with AssetSettingsScene. Apply SceneContainer for proper 1rem margin convention. Update MaybePrivateNetworkingSetting, MaybeCustomServersSetting, and MaybeMoneroUserSettings to use EdgeCard sections wrapper.
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
| <SettingsHeaderRow label={lstrings.settings_detect_tokens} /> | ||
| <EdgeCard> | ||
| <SettingsRow | ||
| label={lstrings.settings_detect_tokens} |
There was a problem hiding this comment.
Duplicate label text in header and row
Medium Severity
The SettingsHeaderRow on line 60 and the SettingsRow on line 63 both use lstrings.settings_detect_tokens ("Detect & Enable Tokens"), causing the same text to appear twice — once as the section header and again as the action row label immediately below it. The second section correctly uses a distinct header string (lstrings.settings_asset_settings) separate from its row labels, suggesting this duplication in the first section is unintentional.
3 participants
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneRequirements
If you have made any visual changes to the GUI. Make sure you have:
Note
Low Risk
Low risk: primarily UI/layout refactors in settings screens plus an English string tweak; behavior changes are minimal aside from how rows are grouped and rendered.
Overview
Updates settings UI to the UI4 card layout.
AssetSettingsScene,CurrencySettingsScene, and several currency settings components now wrap rows insideSceneContainerandEdgeCard(with section dividers) and switch the token rescan row to aSettingsRowwith a right-side refresh icon.Clarifies privacy wording. The English
settings_network_privacy_defaultstring changes from “Standard (No Privacy)” to “Standard (IP is visible)”, and theCurrencySettingssnapshot is updated to reflect the new card-based layout. Also removesAssetSettingsScene.tsxfrom the special ESLint warning-files list.Written by Cursor Bugbot for commit 088c0fa. This will update automatically on new commits. Configure here.