Skip to content

Move import options into CreateWalletImportScene#5986

Merged
j0ntz merged 2 commits intodevelopfrom
matthew/move-import-options-2
Mar 28, 2026
Merged

Move import options into CreateWalletImportScene#5986
j0ntz merged 2 commits intodevelopfrom
matthew/move-import-options-2

Conversation

@j0ntz
Copy link
Copy Markdown
Contributor

@j0ntz j0ntz commented Mar 24, 2026

Additional change on #5982. This replaces that PR

CHANGELOG

Does this branch warrant an entry to the CHANGELOG?

  • Yes
  • No

Dependencies

none

Requirements

If you have made any visual changes to the GUI. Make sure you have:

  • Tested on iOS device
  • Tested on Android device
  • Tested on small-screen device (iPod Touch)
  • Tested on large-screen device (tablet)

Note

Medium Risk
Touches the wallet import flow UI and validation for per-currency import options, which could block imports or mis-handle required fields if regressions occur. Changes are localized to the import scene plus lint config.

Overview
Refactors CreateWalletImportScene to collect import key options inline instead of via an editable row + modal, using FilledTextInput fields with per-option validation/required handling.

Adds an in-row info button that opens any option knowledgeBaseUri, shows the currency header only when multiple plugins are present, and tweaks return-key behavior and spacing styles. Updates eslint.config.mjs to include CreateWalletCompletionScene.tsx in the TypeScript project-service linting block.

Written by Cursor Bugbot for commit df3f7aa. This will update automatically on new commits. Configure here.


Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Autofix Details

Bugbot Autofix prepared a fix for the issue found in the latest run.

  • ✅ Fixed: Number-pad keyboard with unsupported returnKeyType on iOS
    • Added platform-aware returnKeyType that uses undefined on iOS when inputType is number-pad, following the platform-keyboard rule.

Create PR

Or push these changes by commenting:

@cursor push f9697bdd3f
Preview (f9697bdd3f)
diff --git a/src/components/scenes/CreateWalletImportScene.tsx b/src/components/scenes/CreateWalletImportScene.tsx
--- a/src/components/scenes/CreateWalletImportScene.tsx
+++ b/src/components/scenes/CreateWalletImportScene.tsx
@@ -318,7 +318,11 @@
                     onChangeText={(text: string) => {
                       handleOptionChange(text, pluginId, opt)
                     }}
-                    returnKeyType="done"
+                    returnKeyType={
+                      opt.inputType === 'number-pad' && Platform.OS === 'ios'
+                        ? undefined
+                        : 'done'
+                    }
                   />
                 )
               })}

This Bugbot Autofix run was free. To enable autofix for future PRs, go to the Cursor dashboard.

Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

if (item == null) return null

const { value, error } = item
const { knowledgeBaseUri } = opt.displayDescription ?? {}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Import option description message text is dropped

Medium Severity

The displayDescription.message field is no longer displayed anywhere in the new inline input UI. Only knowledgeBaseUri is destructured at line 304, and the message property is silently ignored. Previously, the TextInputModal rendered this message as descriptive text (e.g., "The birthday height is the network block height…" or "A passphrase is an optional extra word or phrase you add to your recovery seed"). For the monero passphrase option, which has no knowledgeBaseUri, the user now receives zero contextual guidance about the field's purpose.

Fix in Cursor Fix in Web

Copy link
Copy Markdown
Contributor

@peachbits peachbits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The support team may care about the description getting left out, but I don't.

@j0ntz j0ntz force-pushed the matthew/move-import-options-2 branch from 258aad7 to df3f7aa Compare March 28, 2026 01:09
@j0ntz j0ntz merged commit aa6755d into develop Mar 28, 2026
3 of 4 checks passed
@j0ntz j0ntz deleted the matthew/move-import-options-2 branch March 28, 2026 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants