Conversation
paullinator
force-pushed
the
paul/addKado
branch
from
e31378f to
b621be8
Compare
samholmes
left a comment
samholmes
left a comment
There was a problem hiding this comment.
Approved, but I think cleanup by putting dead-code in a separate commit and separate wip-branch may be better then committing it now.
src/partners/kado.ts
Outdated
| // const statusMap: { [key in PartnerStatuses]: Status } = { | ||
| // DONE: 'complete', | ||
| // other: 'other' | ||
| // } |
There was a problem hiding this comment.
Commented out code meant for a later PR makes it very hard to review because I don't know if this is accidental or not. Can you stash these commented out portions in a local stash or branch?
src/partners/kado.ts
Outdated
| // break | ||
| } | ||
| } | ||
| // await snooze(3000) |
There was a problem hiding this comment.
Accidental or for a later PR?
src/partners/kado.ts
Outdated
|
|
||
| const MAX_RETRIES = 5 | ||
| const QUERY_LOOKBACK = 1000 * 60 * 60 * 24 * 30 // 30 days | ||
| const QUERY_TIME_BLOCK_MS = QUERY_LOOKBACK |
There was a problem hiding this comment.
Why the extra constant?
src/partners/kado.ts
Outdated
| const startTimeS = startTime / 1000 | ||
| const endTimeS = endTime / 1000 |
There was a problem hiding this comment.
how does this not give you unused variable errors?
src/partners/kado.ts
Outdated
| // No looping since all txs are returned in one call for now | ||
| // while (true) | ||
| { |
There was a problem hiding this comment.
Why not just make a separate commit for the while-loop and time variables which can be in a separate wip-branch?
paullinator
force-pushed
the
paul/addKado
branch
from
b621be8 to
4b2aeef
Compare
|
@samholmes since this code is already deployed in develop, i'll see if they update the API in the near future and I'll just modify this PR for the new API. Otherwise if I get impatient, I'll pull out the dead code. |
paullinator
force-pushed
the
paul/addKado
branch
3 times, most recently
from
502433b to
93458a1
Compare
paullinator
force-pushed
the
paul/addKado
branch
2 times, most recently
from
9cbd4b6 to
bb51763
Compare
paullinator
force-pushed
the
paul/addKado
branch
from
bb51763 to
c17c803
Compare
2 participants
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneDescription
none