Skip to content

chore: pin runner image version#93

Merged
pfeerick merged 2 commits intomainfrom
pfeerick/change-runs-on
Feb 3, 2025
Merged

chore: pin runner image version#93
pfeerick merged 2 commits intomainfrom
pfeerick/change-runs-on

Conversation

@pfeerick
Copy link
Copy Markdown
Member

@pfeerick pfeerick commented Feb 3, 2025

I suspect there are some dependency issues due to githubs recent change to Ubuntu-24.04 for the ubuntu-latest image

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.53%. Comparing base (ff0859b) to head (691871c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main      #93    +/-   ##
========================================
  Coverage   39.53%   39.53%            
========================================
  Files         103      103            
  Lines       12009    12009            
  Branches      645      490   -155     
========================================
  Hits         4748     4748            
  Misses       7254     7254            
  Partials        7        7            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Will continue to be supported and available for the next two years
@pfeerick pfeerick changed the title chore: downgrade runner image chore: pin runner image version Feb 3, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 3, 2025

EdgeTX Buddy has been automatically deployed to Cloudflare.
✅ Preview: https://75eb5391.buddy-7a6.pages.dev
✅ Storybook: https://75eb5391.buddy-7a6.pages.dev/storybook

@pfeerick pfeerick marked this pull request as ready for review February 3, 2025 22:31
@pfeerick pfeerick merged commit 6810861 into main Feb 3, 2025
@pfeerick pfeerick deleted the pfeerick/change-runs-on branch February 3, 2025 22:37
pfeerick added a commit to pfeerick/buddy that referenced this pull request May 3, 2025
pfeerick added a commit to pfeerick/buddy that referenced this pull request May 5, 2025
pfeerick added a commit that referenced this pull request May 5, 2025
* fix: preview-web can't be run on forks

GitHub repo SECRETS are not exposed to forks, thus the preview-web step can't be run on pull requests from forks.

* chore: first attempt at permission dependent building

From what I can see, it appears to be linked to the checkout, so may need to be done for both compile and storyboard steps as they are dependencies of preview-web.

* chore: poke around a little more

* chore: can I transfer the result directly?

* chore: comments and test if secrets available

* fix: typo in test

* chore: try replacing all checkout events... just because

* chore: add dependency check, also fallback for non PR checkouts

* chore: split workflows... 2/3

* fix: finish removing permission check crud

* chore: remove secrets check

* chore: stage1 dependency, download from prior workflow

* chore: hopefully functional release stage

* fix: missing `jobs`

* fix: if test at wrong level

* chore: rename workflows

* chore: run formatter

* chore: reapply #93

* chore: reapply #98
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant